Closed Bug 69361 Opened 24 years ago Closed 24 years ago

Add reflow counts on frame by frame basis

Categories

(Core :: Layout, defect)

x86
Windows NT
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: rods, Assigned: rods)

Details

(Whiteboard: fix in hand)

Attachments

(1 file)

No description provided.
accepting
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Target Milestone: --- → mozilla0.9
Attached patch patch file (deleted) — Splinter Review
r=attinasi - minor stuff below: Range check on the aType to avlod Seg Fault? + PRUint32 GetTotalByType(nsReflowReason aType) { return mTotals[aType]; } Combine ctors + IndiReflowCounter() :mMgr(nsnull),mFrame(nsnull),mParent(nsnull), mCount(0), mHasBeenOutput(PR_FALSE) {} + IndiReflowCounter(ReflowCountMgr * aMgr):mMgr(aMgr),mCounter(aMgr),mFrame(nsnull),mParent(nsnull), mCount(0), mHasBeenOutput(PR_FALSE) {} could be IndiReflowCounter(ReflowCountMgr * aMgr=nsnull):mMgr(aMgr),mCounter(aMgr),mFrame(nsnull),mParent(nsnull), mCount(0), mHasBeenOutput(PR_FALSE) {} Check for null ReflowCountMgr::Add allocates counter and never checks it (only asserts, which is strange for a memory allocation) DoSingleIndi should maybe ASSERT for name not being null? Comments Hmm - didn't really see any... maybe a hight-lvel description of how the stats are accumulated would be nice (for future generations).
Assuming you did what marc said, sr=waterson. :-)
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Marking verified per last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: