Closed Bug 69483 Opened 24 years ago Closed 22 years ago

Prevent submitting twice, opening two PSM windows, etc by double clicking.

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

PowerPC
Mac System 9.x
defect

Tracking

()

RESOLVED WORKSFORME
mozilla1.0.1

People

(Reporter: tarahim, Assigned: alecf)

Details

Attachments

(1 file)

When you double click a submit button, PSM padlock icon, etc, Mozilla tries to submit twice, open two PSM windows, etc. This should be avoided. Opening a PSM window is quite dangerous currently, because of memory leak. Submitting twice usually result in a dialog hidden by a refreshed window, resulting in apparent unresponsiveness of Mozilla. Send mail is now disabled from double action, I think, and these can be avoided, too.
Any progress on this? I took a quick look in viewer and the content model looks correct; e.g., iframe@00F57080 width=100% height=100% src=http://www.iwin.com refcount=4< Yet the content area still shows www.yahoo.com.
Attached patch add logging to nsDocShell.cpp (deleted) — Splinter Review
nsDocShell.cpp thinks it's loading the right URL.
Oops wrong bug. Dammit!
Gerardo, could we get a current test on both mac and windows? We should fix this if it's still happening. Can this be fixed in XUL code?
Keywords: nsbeta1, qawanted
Over to Chris. If retest shows a problem we'll need our Mac guy on it.
Assignee: joki → saari
Give this to someone else. Make sure the xul is looking for mouseclick and not mouse down (which you'll see two of).
Assignee: saari → hangas
Oops, hangas was a mistarget. Does this fall into xpapps?
Assignee: hangas → vishy
yes we should fix this. pretriaging as nsbeta1+. reassigning to Alec.
Assignee: vishy → alecf
4.x never did this - I don't see why this is a beta-stopper! Suggestting nsbeta1-
Priority: -- → P3
Target Milestone: --- → mozilla1.0
nav triage team: Marking nsbeta1-, although annoying, proper fix would require a lot of work, not a beta1 stopper.
Keywords: nsbeta1nsbeta1-
QA contact updated
QA Contact: gerardok → madhur
nav triage team: Not a mozilla1.0 stopper, pushing out to mozilla1.0.1
Target Milestone: mozilla1.0 → mozilla1.0.1
If double submit goes away, so does this, correct?
Depends on: 72906
hrm, PSM windows, at least, are not using <form>. The double-submit fix does not keep multiple windows from opening. Un-depending.
No longer depends on: 72906
QA Contact: madhur → rakeshmishra
I think this was fixed by jkeiser with the double-submit bug. marking WORKSFORME unless someone can find the dupe.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
QA Contact: rakeshmishra → trix
Keywords: qawanted
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: