There is a sloppy string in the RDF serialization code. It needs to be fixed to use a constant. Index: nsRDFXMLDataSource.cpp =================================================================== RCS file: /cvsroot/mozilla/rdf/base/src/nsRDFXMLDataSource.cpp,v retrieving revision 1.33 diff -c -r1.33 nsRDFXMLDataSource.cpp *** nsRDFXMLDataSource.cpp 1999/05/13 20:53:07 1.33 --- nsRDFXMLDataSource.cpp 1999/05/24 03:12:22 *************** *** 1231,1240 **** nsXPIDLCString s; if (NS_SUCCEEDED(aContainer->GetValue( getter_Copies(s) ))) { nsAutoString uri(s); rdf_PossiblyMakeRelative((const char*) docURI, uri); rdf_EscapeAmpersands(uri); ! rdf_BlockingWrite(aStream, " ID=\"", 9); rdf_BlockingWrite(aStream, uri); rdf_BlockingWrite(aStream, "\"", 1); } --- 1231,1242 ---- nsXPIDLCString s; if (NS_SUCCEEDED(aContainer->GetValue( getter_Copies(s) ))) { + static const char kIDEquals[] = " ID=\""; + nsAutoString uri(s); rdf_PossiblyMakeRelative((const char*) docURI, uri); rdf_EscapeAmpersands(uri); ! rdf_BlockingWrite(aStream, kIDEquals, sizeof(kIDEquals) - 1); rdf_BlockingWrite(aStream, uri); rdf_BlockingWrite(aStream, "\"", 1); } This is a brain-dead fix that should go into M6.

ok.

QA: Please set verifier field to waterson@netscape.com.

chris, you can verify when ready (or i can change the QA Contact to you, or i could bonk it verified for you) thanks

hope this is the right thing to do, per your 05/23 comment.