Closed
Bug 6968
Opened 26 years ago
Closed 26 years ago
Disable "brprof" by default on Unix
Categories
(Core Graveyard :: RDF, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M6
People
(Reporter: waterson, Assigned: waterson)
Details
(Whiteboard: fix proposed, awaiting review & test)
Autoconfig currently has "browsing profile" on by default for Unix. We should
update this to be OFF by default.
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M6
Assignee | ||
Updated•26 years ago
|
Whiteboard: fix proposed, awaiting review & test
Assignee | ||
Comment 1•26 years ago
|
||
Okay, here's the fix.
Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.324
diff -c -r1.324 configure.in
*** configure.in 1999/05/21 10:12:30 1.324
--- configure.in 1999/05/24 16:39:22
***************
*** 1256,1265 ****
AC_DEFINE(ENABLE_PICS)
dnl Build browsing profile by default
! MOZ_BRPROF=1
! MOZ_ARG_DISABLE_BOOL(brprof,
! [ --disable-brprof Disable browsing profile cookie],
! [MOZ_BRPROF= ] )
AC_DEFINE(MOZ_BRPROF)
--- 1256,1265 ----
AC_DEFINE(ENABLE_PICS)
dnl Build browsing profile by default
! MOZ_BRPROF=
! MOZ_ARG_ENABLE_BOOL(brprof,
! [ --enable-brprof Enable browsing profile cookie],
! [MOZ_BRPROF=1] )
AC_DEFINE(MOZ_BRPROF)
Shaver, bruce, could you code review that for me and make sure it seems sane.
I'm rebuilding with this now...
Assignee | ||
Comment 2•26 years ago
|
||
Okay, let's try that diff one more time. I wasn't actually _undeffing_
MOZ_BRPROF on the command line:
Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.324
diff -c -r1.324 configure.in
*** configure.in 1999/05/21 10:12:30 1.324
--- configure.in 1999/05/24 17:09:08
***************
*** 1256,1267 ****
AC_DEFINE(ENABLE_PICS)
dnl Build browsing profile by default
! MOZ_BRPROF=1
! MOZ_ARG_DISABLE_BOOL(brprof,
! [ --disable-brprof Disable browsing profile cookie],
! [MOZ_BRPROF= ] )
!
! AC_DEFINE(MOZ_BRPROF)
dnl ========================================================
dnl =
--- 1256,1265 ----
AC_DEFINE(ENABLE_PICS)
dnl Build browsing profile by default
! MOZ_ARG_ENABLE_BOOL(brprof,
! [ --enable-brprof Enable browsing profile cookie],
! MOZ_BRPROF=1
! AC_DEFINE(MOZ_BRPROF))
dnl ========================================================
dnl =
Assignee | ||
Comment 3•26 years ago
|
||
Added ramiro: hey ramiro, could you take a look at these diffs and see if they
look ok? Bruce has to work at his real job, and shaver just went AWOL.
Assignee | ||
Comment 4•26 years ago
|
||
Okay, maybe mcafee? Chris, can you talk a look at the second patch and let me
know if it seems reasonable? Seems to work...
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•26 years ago
|
||
r=mcafee, a=chofmann
code level fix. i'm marking as verified. if you disagree, please scold me as
appropriate.
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•