Closed
Bug 698088
Opened 13 years ago
Closed 13 years ago
Initializing WebGL fake-black textures doesn't rebind previous texture bindings before drawing
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
When there are textures in a context which (for an as-per-spec reason) must be rendered as black, we initialize face-black textures as a prefix to the next draw. When creating these textures, we naturally must change the current texture bindings, which is fine, as long as we reset them to their previous state when we're done. However, instead, we reset the 2d and cubemap textures to 0, instead of the previous values.
This causes the conformance tests for copyTexImage2D and copyTexSubImage2D to fail.
|
Assignee | |
Comment 1•13 years ago
|
||
Short and sweet, but unbelievably annoying to track down. APITrace is awesome, though.
Attachment #570362 -
Flags: review?(bjacob)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Removed copyTexImage2D and copySubTexImage2D from list of failing tests for all platforms.
Attachment #570362 -
Attachment is obsolete: true
Attachment #570362 -
Flags: review?(bjacob)
Attachment #570372 -
Flags: review?(bjacob)
|
||
Updated•13 years ago
|
Attachment #570372 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
|
|
Assignee | |
Comment 4•13 years ago
|
||
Removed [inbound] from whiteboard as per https://wiki.mozilla.org/Tree_Rules/Inbound
Whiteboard: [inbound]
Target Milestone: mozilla10 → ---
|
|
Assignee | |
Updated•13 years ago
|
Target Milestone: --- → mozilla10
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•