Closed Bug 7002 Opened 25 years ago Closed 25 years ago

Speed up mail by removing call to UpdateSummaryTotals

Categories

(MailNews Core :: Backend, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: scottputterman, Assigned: scottputterman)

References

Details

(Whiteboard: [Perf])

I found that we could speed up mail to take 1/6 of the time to load headers if we remove the call to UpdateSummaryTotals in OnAddKey. The side effect of this is that message counts won't appear correctly in the folder pane and that styles in the thread pane don't show up correctly until you mouse over the affected header. But I think both of these side effects are worth introducing and figuring out later to get the speed gain.
Target Milestone: M6
Status: NEW → RESOLVED
Closed: 25 years ago
Hardware: PC → All
Resolution: --- → FIXED
I checked in a fix for this.
Hardware: All → PC
If you fix this for M6, we'll need to document the side effects in the release notes. Thanks.
Par or Suresh, can you verify this in the code?
QA Contact: 4080 → 4421
Scott - in which file(s) is the fix? Par
base\util\nsMsgDBFolder.cpp in the function OnAddKey. I just commented out the call to UpdateSummaryTotals. You'll only see the difference if you have to reparse your mailbox folder.
Whiteboard: [Perf]
Putting on [Perf] radar
Blocks: 6619
Status: RESOLVED → VERIFIED
Current code shows: NS_IMETHODIMP nsMsgFolder::UpdateSummaryTotals() { //We don't support this return NS_OK; } VERIFIED as acceptable code
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.