Closed Bug 70244 Opened 24 years ago Closed 21 years ago

seamonkey-build not warning when embed make fails

Categories

(SeaMonkey :: Build Config, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED WONTFIX
mozilla1.5beta

People

(Reporter: granrosebugs, Assigned: lpham)

Details

Attachments

(1 file)

See errors in bug 70328. There should be a test on the return status of the make in embedding/config that should at least mail a warning when it fails rather than just checking if the tarball exists after the make completes. We have been delivering an invalid embedding tarball for linux since 2001-02-23-06. It should be something like if [ "$?" -ne "0" ]; then mail_warn "embed make failed" else copy files fi right after the make command. cc'ing lpham so she can see the patch start learning a little about the seamonkey unix automation.
Depends on: 70238
No longer depends on: 70238
accepting bug... changing summary to reflect reality.
Status: NEW → ASSIGNED
Summary: seamonkey-spawn not warning when embed make fails → seamonkey-build not warning when embed make fails
Priority: -- → P3
Target Milestone: --- → mozilla0.9.2
Target Milestone: mozilla0.9.2 → mozilla1.0
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
that can't be the right bug #. regardless, this should still be fixed if it's still not in the current trunk automation. reassigning to lpham, cc kysmith.
Assignee: leaf → lpham
Status: ASSIGNED → NEW
Target Milestone: mozilla1.0.1 → mozilla1.5beta
Attachment #123420 - Flags: superreview?(leaf)
Attachment #123420 - Flags: review?(granrose)
Status: NEW → ASSIGNED
Comment on attachment 123420 [details] [diff] [review] send warning message when embed make fails r=granrose. changing sr to kysmith to get a second set of eyes.
Attachment #123420 - Flags: superreview?(leaf) → superreview?(kysmith)
Attachment #123420 - Flags: superreview?(kysmith) → superreview+
Comment on attachment 123420 [details] [diff] [review] send warning message when embed make fails r= Jon Granrose via comment #5
Attachment #123420 - Flags: review?(granrose) → review+
engineer gone, wontfix. if you want it, reopen the bug and reassign it to yourself.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: