Closed
Bug 70263
Opened 24 years ago
Closed 24 years ago
Named Anchor Properties: should be able to enter dash
Categories
(Core :: DOM: Editor, defect, P3)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: bugzilla, Assigned: cmanske)
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
found using 2001.02.26.08 commercial bits. in the Named Anchor Properties
dialog, i can enter alphanumeric or underscore characters. i should be able to
enter dash as well, but i cannot. [since ascii chars are legal for named anchors.]
Reporter | ||
Comment 1•24 years ago
|
||
just to be clear: when i hit the dash key, no character appears in the textfield
of this dialog.
Keywords: mozilla0.9,
nsbeta1
Comment 2•24 years ago
|
||
yes, you should be able to use a dash, assigning to cmanske
Assignee: beppe → cmanske
Priority: -- → P3
Target Milestone: --- → mozilla0.9.1
Assignee | ||
Comment 3•24 years ago
|
||
Yes, I was just commenting! We should also allow "." and "+", right?
I see lots of examples using "." and "-" in the W3C site.
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.1 → mozilla0.9
Assignee | ||
Comment 4•24 years ago
|
||
Comment 6•24 years ago
|
||
Why don't we allow other characters like: * or , or =
Assignee | ||
Comment 7•24 years ago
|
||
I couldn't find a definitive list of non-letter/number characters allowed in a
URL. Since "*" is used for filename wildcards, I didn't think that would be legal.
I thought of "=", but figured it wouldn't be needed?
Reporter | ||
Comment 8•24 years ago
|
||
from the html 4.01 spec: http://www.w3.org/TR/html4/struct/links.html#edef-A
--the name attribute takes any cdata:
http://www.w3.org/TR/html4/types.html#type-cdata
Assignee | ||
Comment 9•24 years ago
|
||
Thanks! So here's the word:
NAME tokens must begin with a letter ([A-Za-z]) and may be followed by any
number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons
(":"), and periods (".").
So we don't need "*" or "=", but we need to add ":"
Assignee | ||
Comment 10•24 years ago
|
||
Assignee | ||
Updated•24 years ago
|
Whiteboard: FIX IN HAND → FIX IN HAND needs r= sr=
Comment 11•24 years ago
|
||
please fix the comment; after that r=brade
Whiteboard: FIX IN HAND needs r= sr= → FIX IN HAND needs sr=
Comment 12•24 years ago
|
||
One nit pick, the function name PrepareStringForURL() implies to me that it will
do a URL encoding, which it never really did. Perhaps a better name would be
ConvertToCDATAString() since that is exactly what it will be doing after your
changes?
Can we please change the name of the method to avoid confusion?
Other than that, sr=kin@netscape.com
FYI the patch doesn't enforce the fact that the name must begin with a letter,
as you mention above, but we can file that as a separate bug ... the browser
doesn't seem to care if the name begins with a letter or not.
Assignee | ||
Comment 13•24 years ago
|
||
I agree with all recent comments: Comment will be changed and method name will
be ConvertToCDATAString().
Whiteboard: FIX IN HAND needs sr= → FIX IN HAND
Assignee | ||
Comment 14•24 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND
You need to log in
before you can comment on or make changes to this bug.
Description
•