Closed Bug 70267 Opened 24 years ago Closed 24 years ago

Implement gopher searches

Categories

(Core :: Networking, enhancement)

enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: bbaetz, Assigned: bbaetz)

References

()

Details

Attachments

(1 file)

I need to implement gopher searches, remembering darin's comments in bug 61167.
Depends on: 49334
Target Milestone: --- → mozilla1.0
I've done this, but I need to tidy up the dir viewer code so that the listings in the dirviewer are correct. Marking dependancy.
Status: NEW → ASSIGNED
Depends on: 70529
Target Milestone: mozilla1.0 → mozilla0.9
This now works. As a bonus, I no longer add the url to the load group twice. Oops. I've also added another couple of PR_LOG calls. You may need the patches to bug 70529 if you try loading the query url directly - go to the above url, and select the "McGill names and phone numbers" link. ccing darin and dougt for r/sr
Attached patch patch (deleted) — Splinter Review
just one nit: the ASSERTION in SetNotificationCallbacks is probably wrong... the NS_WARNING before attempting to prompt is much better IMO. the client could for whatever reason call SetNotificationCallbacks more than once with a different value for aNotificationCallbacks each time. my point is that it isn't the value of mPrompter when SetNotificationCallbacks is called that matters... it's the value of mPrompter before you go to use it that matters. fix this and r/sr=darin
r=dougt.
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
VERIFIED: mozilla 0.9 all plats.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: