Closed
Bug 70481
Opened 24 years ago
Closed 24 years ago
need to get rid of isModal, isWindowModal redundancy
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.8.1
People
(Reporter: jud, Assigned: danm.moz)
References
()
Details
(Keywords: embed)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
We still have this dual world we need to reconcile. Dan points out this ugly
redundancy:
nsIDocShellTreeOwner nsIWebBrowserChrome
isModal isWindowModal
showModal showAsModal
exitModalLoop exitModalEventLoop
|
||
Comment 3•24 years ago
|
||
The patch makes it a lot cleaner.
r=ccarlen
.
|
||
Comment 5•24 years ago
|
||
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein
|
||
Comment 6•24 years ago
|
||
* isModal(), showModal() and exitModalLoop() removed from nsIDocShellTreeOwner
* showAsModal(), isWindowModal() and exitModalEventLoop() are found in
nsIWebBrowserChrome.
* per contents of the patch:
- the 3 nsIDocShellTreeOwner modals are not implemented in any of these:
nsIDocShellTreeOwner.cpp, nsWindowWatcher.cpp, nsSyncLoader.cpp,
nsXMLHttpRequest.cpp, nsPrefMigration.cpp, nsChromeTreeOwner.cpp, and
WebBrowserChrome.cpp (couldn't find GtkMozEmbedChrome.cpp. is this obsolete?)
- nsContentTreeOwner.cpp uses ShowModal() (line 392) and exitModalLoop (line
403), but these are returned from a XUL Window within implementations of
showAsModal() and exitModalEventLoop() respectively.
Status: RESOLVED → VERIFIED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•