Closed
Bug 706554
Opened 13 years ago
Closed 13 years ago
Add nsRefPtrHashKey
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I wound up needing this for my gamepad patches, since I'm hanging on to nsGlobalWindow* directly instead of using interfaces.
|
Assignee | |
Comment 1•13 years ago
|
||
We don't seem to have comprehensive tests on the hashtable stuff, but I'd be happy to add tests for this to TestHashtables.cpp if you'd like.
Attachment #578014 -
Flags: review?(benjamin)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 578014 [details] [diff] [review]
Add nsRefPtrHashKey
Could we just typedef nsRefPtrHashKey<nsISupports> nsISupportsHashKey? Probably doesn't matter though.
Attachment #578014 -
Flags: review?(benjamin) → review+
We'd lose comptr logging on hash keys then. Whether or not people actually care about that, idk.
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•