Closed Bug 70747 Opened 24 years ago Closed 24 years ago

[XUL Syntax] Replace <textfield> with <textbox>

Categories

(Core :: XUL, defect)

x86
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.0

People

(Reporter: hyatt, Assigned: hyatt)

References

Details

(Keywords: helpwanted, Whiteboard: [XUL1.0])

Attachments

(3 files)

All uses of the <textfield> tag should be replaced with <textbox> instead.
Status: NEW → ASSIGNED
Whiteboard: [XUL1.0]
Depends on: 70753
No longer depends on: 70753
Blocks: 70753
mass-targetting to mozilla1.0, adding helpwanted keyword
Keywords: helpwanted
Target Milestone: --- → mozilla1.0
I'll give this a go.
Attached patch patch - first go at this (deleted) — Splinter Review
This patch seems to be working well for common browsing tasks, but it hasn't been through full-on testing.
Do we still need the atoms? it looks like your patch only touched the .h files and .xul/js files, could be that we could safely remove the atoms...
Ben, which atoms are you talking about? I see that the patch replaced the textfield atom with the textbox atom. What others?
Make sure you keep this patched tree around, maolson, so you can produce updated patches. Hopefully we can get this landed soon, so you don't get a lot of conflicts.
I anticipated that there might be some delays and subsequent merge conflicts, so I have this in its own tree. I'll keep it close to the tip, so it can be landed whenever you are ready. Since this is working pretty well locally for me, my main concern is the fallout others are going to have (Activestate, commercial NS, AIM, etc.) from this. I would assume this eventuality has been planned for, so let me know if there is anything I can do to facilitate the transition.
If you'd like, you could make a post to .xpfe saying that you have this syntax change ready to go, and that others should be prepared.
Dave: I think Ben is referring to the fact that if only the atom list was changed, and things still built okay, then the atom can probably be removed from the list (since no .cpp changes were required; lxr confirms that nsXULAtoms::textfield isn't in use anywhere). I also have lots of syntax changes in a separate tree. Mail needs to merge soon, because conflicts are going to be hell if people touch the FE in the meantime (and the longer they wait, the harder it's going to be for them to merge anyways).
Ok, talking with blake and he has his value -> label patch ready or nearly ready. It would be nice if we could land both in a mini carpool on monday if possible (leaf indicated it would be ok if verification gets done in time). Of course, to do that we need commercial and security checkins to happen as well. The leftovers output I attached doesn't include mozilla/security or commerical. I know there are a few <textfields> in security, and presumably aim uses a textfield or two. I'd like to get r/sr from ben and hyatt on this, then figure out who to round up to manage the other changes. If you guys see anything in the leftovers that needs renaming, let me know.
dave, the textfield/textbox atom is not used by layout anywhere. seems we could just remove it. a minor issue, not worth generating & attaching another patch for, but a reasonable cleanup ;)
fix checked into mozilla. prass and kerz have the commercial side covered. bryner took care of security. As another potential cleanup, textfield.css files _could_ be renamed.
(forgot to note since it didn't get into this bug, changes were r=blake, a=ben via irc)
Thanks, maolson!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Just for clarity sake, is this going into 0.8.1 as well, or do I need to maintain a fork?
This bug and bug 70746, which landed alongside, are not intended to be landed on the 0.8.1 branch.
Hey, Mark, wanna do the <titledbox> to <groupbox> conversion? Should be easier than this one was...
Dave, looks like blake indicated he already has some work into that one... I'm looking at the <tab*/> bug as a possible next mistake^W step.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: