Closed
Bug 7077
Opened 26 years ago
Closed 26 years ago
compile-et should put comments in generated .h file
Categories
(NSPR :: NSPR, enhancement, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgmyers, Assigned: wtc)
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Fix attached
|
Reporter | |
Comment 1•26 years ago
|
||
|
Assignee | |
Comment 2•26 years ago
|
||
|
|
Assignee | |
Updated•26 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•26 years ago
|
||
I modified your proposed fix to put the comments
on their own lines and add blank lines in between,
so that the generated header looks like:
/*
*
* prerr.h
* This file is automatically generated; please do not edit it.
*/
/* Memory allocation attempt failed */
#define PR_OUT_OF_MEMORY_ERROR (-6000L)
/* Invalid file descriptor */
#define PR_BAD_DESCRIPTOR_ERROR (-5999L)
/* The operation would have blocked */
#define PR_WOULD_BLOCK_ERROR
...
|
|
Reporter | |
Comment 4•26 years ago
|
||
wtc's patch is fine by me.
|
|
Assignee | |
Comment 5•26 years ago
|
||
The mozilla.org cvs repository is closed now for the M6
milestone, so I checked in the fix to the internal cvs
repository.
/m/src/ns/nspr20/pr/include/prerr.h, revision 2.4
/m/src/ns/nspr20/pr/src/misc/compile-et.pl, revision 2.5
|
|
Assignee | |
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•26 years ago
|
||
Checked in the fix to cvs.mozilla.org:
/cvsroot/mozilla/nsprpub/pr/include/prerr.h, revision 3.4
/cvsroot/mozilla/nsprpub/pr/src/misc/compile-et.pl, revision 3.5
You need to log in
before you can comment on or make changes to this bug.
Description
•