Closed
Bug 714261
Opened 13 years ago
Closed 13 years ago
TransactionManager used as a service
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: smaug, Assigned: tetsuharu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
TransactionManager is not a service.
|
||
Comment 1•13 years ago
|
||
well, we expose it through a lazy getter, so most likely it's just matter of swapping getService with createInstance.
thanks for the heads up!
|
Assignee | |
Comment 2•13 years ago
|
||
Is this bug's purpose adding the lazy getter of nsITransactionManager to Services.jsm?
|
Reporter | |
Comment 3•13 years ago
|
||
This bug's purpose is to remove using TransactionManager as a service, because it is not a service.
|
|
||
Comment 4•13 years ago
|
||
so basically, I assume replace getService with createInstance is enough
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #598474 -
Flags: review?(mak77)
|
|
||
Updated•13 years ago
|
Assignee: nobody → saneyuki.s.snyk
Status: NEW → ASSIGNED
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 598474 [details] [diff] [review]
Replace getService with createInstance
Review of attachment 598474 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you!
Attachment #598474 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Rebased patch for check-in.
Attachment #600673 -
Flags: review?(mak77)
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 600673 [details] [diff] [review]
[for check-in] Replace getService with createInstance v1.1
Review of attachment 600673 [details] [diff] [review]:
-----------------------------------------------------------------
thank you.
Attachment #600673 -
Flags: review?(mak77) → review+
|
|
||
Updated•13 years ago
|
Attachment #598474 -
Attachment is obsolete: true
|
||
Comment 9•13 years ago
|
||
|
||
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•