Closed
Bug 71511
Opened 24 years ago
Closed 24 years ago
clean up nsIGlobalHistory
Categories
(Core Graveyard :: History: Global, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: jud, Assigned: alecf)
References
()
Details
(Whiteboard: fix in hand)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
It's an implementation detail that should not live in a public iface.
Assignee | ||
Comment 1•24 years ago
|
||
Can't I just make this a dupe of 71482? :)
Assignee | ||
Comment 2•24 years ago
|
||
eh, screw it. I have an API fix that I'm going to roll into this.
Summary: nsIGlobalHistory should remove addTitle() method. → clean up nsIGlobalHistory
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
I'll clean up the comment for isVisited()
I removed the whole referrer thing because nobody seems to actually use it (yet)
at some point we'll probably set that information at the same time we set the
page title, so for now I'll leave it alone in the database.
Assignee | ||
Updated•24 years ago
|
Whiteboard: fix in hand
Reporter | ||
Comment 5•24 years ago
|
||
nice! r=valeski.
Reporter | ||
Comment 6•24 years ago
|
||
actually, r=valeski after a comment on IsVisited(). Maybe point it back to
AddPage() w/ something like.
IsVisited() returns TRUE if a page had been passed into AddPage(). If the string
passed into IsVisited was never passed into AddPage(), return FALSE.
sr=shaver
Assignee | ||
Comment 8•24 years ago
|
||
oops, I forgot that checked this in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 9•22 years ago
|
||
mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.
if you think this particular bug is not fixed, please make sure of the following
before reopening:
a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).
thanks!
[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•