Closed
Bug 715210
Opened 13 years ago
Closed 13 years ago
Remove some WINCE leftovers in comm-central
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(2 files)
|
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
NB: For this bug, I am ignoring config* files.
Flags: in-testsuite-
|
Assignee | |
Comment 1•13 years ago
|
||
I am not sure what to do with
{
/mailnews/imap/src/nsImapProtocol.cpp
* line 7219 -- // global variable for unusued name spaces from??? *wince*
}
so I left it alone too.
Attachment #585817 -
Flags: review?(mbanner)
|
||
Updated•13 years ago
|
Attachment #585817 -
Flags: review?(mbanner) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 585817 [details] [diff] [review]
(Av1) Remove 4 more WINCE occurrences
[Checked in: Comment 2]
http://hg.mozilla.org/comm-central/rev/9eda40ffb503
Attachment #585817 -
Attachment description: (Av1) Remove 4 more WINCE occurrences → (Av1) Remove 4 more WINCE occurrences
[Checked in: Comment 2]
|
|
Assignee | |
Comment 3•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> I am not sure what to do ...
> so I left it alone too.
Ah, it just occurred to me that this occurrence is not referencing Windows CE ;->
Let's remove it anyway: "code cleanup".
Attachment #585864 -
Flags: review?(dbienvenu)
|
||
Comment 4•13 years ago
|
||
Comment on attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]
kinda sad that we can't use the perfectly good word "wince" in our comments. I'll r+ it for the tab removal. In any case, can you fix the spelling of unused? thx.
Attachment #585864 -
Flags: review?(dbienvenu) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Comment on attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]
http://hg.mozilla.org/comm-central/rev/7fd4f1e85fa0
Bv1, with comment 4 suggestion(s).
Attachment #585864 -
Attachment description: (Bv1) Remove last "wince" occurrence (in Imap code) → (Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•