Closed Bug 71869 Opened 24 years ago Closed 24 years ago

XML Extras module not loaded at startup in embedding case

Categories

(Core :: XML, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: hjtoi-bugzilla, Assigned: hjtoi-bugzilla)

References

Details

(Keywords: embed, Whiteboard: [fixinhand])

Attachments

(1 file)

XML Extras uses appshell to get loaded at startup. This is not used in the embedidng world. Instead, nsIAppStartupNotifier method is used (a startup observer). Make it so XML Extras gets loaded in the embedding case as well as normal browser. This is blocking testing of XML Extras component in the embedding case.
I have a fix for this in my tree, will attach (requires that you repply the patch and work around the makefile case problems in bug 68720, added dependency). I have a problem, though. With the startup observer method the component works ok in the embedded case, but it no longer functions in the normal browser. I was under the impression that the startup observer would also work in browser. If that is a wrong assumption, I can make it so the module implements both appshell and startup observer method of getting loaded at startup.
Status: NEW → ASSIGNED
Depends on: 68720
Keywords: nsbeta1, nsdogfood
Priority: -- → P1
Whiteboard: [fixinhand]
Target Milestone: --- → mozilla0.9
Alec, Chak Nanga suggested that I should ask you to look at my patch here. I changed the XML Extras startup loading from appshell (which does not work in embedding world) to use the startup observer method (this bug depends on the startup observer landing which was busted). So now it works in the embedded case, but not in the normal browser. Chak emailed me one possible explanation: in nsEmbedAPI.cpp he creates the app startup notifier, but it is probably not created anywhere in the normal browser. Do you think that is the case, and if so, where would be a good place to create that for the normal browser? Or could it be something else?
Yes, this is not turned on in either embedding OR seamonkey, and can't until chak's stuff is turned on. Once he turns it on for embedding, I will turn it on for seamonkey.
Alec, is bug 60117 the bug to enable this in Seamonkey? Anyway, once you figure out what it is, could you make that bug block this bug and bug 72143 in Bugzilla. Chak, seems like you fixed 68720, wanna mark it fixed? ;) Also, do you know why gtkEmbed does not load my library at startup (winEmbed does)? Chak/Alec, can you r/sr the patch here? I have one change in my own tree in addition to the patch here, and that is to replace the last arg to AddCategoryEntry() with nsnull.
gtkEmbed seems to be the bad fruit in the basket: * winEmbed (win32) - OK * PPEmbed (Mac) - OK * gtkEmbed (Linux) - XMLHttpRequest not defined, but component registered OK gtkEmbed does not call NS_InitEmbedding() in nsEmbedAPI.cpp. I added blizzard and pavlov to Cc. Added dependency to bug 72741 (gtkEmbed does not call NS_InitEmbedding). It blocks this from working on Linux, but I can still check this in without it so it will work elsewhere.
Depends on: 72741
Looks good to me...r=chak
Severity: blocker → major
Did you try it in TestGtkEmbed? It should work there afaik.
Ah, TestGTKEmbed works, thanks!
Vidur says sr=vidur. Alec, can you give an ETA on the browser part of this (bug 60117)?
Fix checked in. jst is watching the checkin for me, going home.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Marking verified last comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: