Using mar13 commercial trunk build Today's build has a messed up criteria area in both the search messages and message filters ui. There are two extra dropdowns (Priority values, Status values) to the right of the proper criteria dropdowns. 1. From mail window Edit|Message Filters. Click New to open filter rules dialog. Note the two extra dropdowns on the criteria line at the right side. 2. From mail window Search|Search MailNews Messages. Note the two extra dropdowns on the criteria line. So far, the presence of the extra dropdowns don't appear to affect a properly entered search/filter. I know there are some other ui problems in today's build (thread pane columns). Will double-check again in next builds.

.

FYI -- still present in mar16 commercial trunk

*** Bug 72544 has been marked as a duplicate of this bug. ***

*** Bug 72612 has been marked as a duplicate of this bug. ***

*** Bug 73054 has been marked as a duplicate of this bug. ***

marking nsbeta1+ and moving to mozilla0.9.1

These extra dropdowns are inhibiting the display area of the subject/sender text field -- a pain.

*** Bug 75471 has been marked as a duplicate of this bug. ***

These dropdowns are also in the way if choosing a fixed value criteria choice, such as Status -- the criteria dropdown for status (the "extra" one) doesn't retain choice, can't tell if option is just broken or can't work because of these dropdowns.

The deck that holds the edit field, priority drop down, and status dropdown is not functioning. I don't know why. It's being told to change it's current index but it's not actually doing it. So instead of only showing one, it's always showing all 3.

moving to mozilla0.9

moving to mozilla0.9.1

ok, making progress on this. I taked to evaughan, and you can't use XBL to extend deck. (known problem, but no bug on it yet. I'll log a bug on it.) I'm working on a work around that he suggested.

as I mentioned, evaughan told me that decks won't work with in XBL. I've gotten better results by crudely hiding and showing the content on my own. the only thing not working with this patch is I'm unable to switch the menulist values. I was able to search for all messages with "pics" and with status == replied, so things work. we're almost there.

This patch fixes the problem where the menulist's were not updating when you selected an item.

taking. the bug will eventually go to hyatt or hewitt, but I'll drive it in. good news, we've got a patch here that works around the badness. even better news, hyatt thinks deck should work with XBL, so we might not have to make the ugly hack to mailWidgets.xml. we still need hewitt's patch (which is not an workaround hack), otherwise the priority and status pickers don't work right. I'll apply hewitt's patch to my tree and bake with it. (hewitt, can you bake with it in your local tree, too?) it would be great to land something into 0.9. after baking hewitt's patch, any objections to landing the work around to 0.9, but wait for hyatt's fix for the trunk?

Just a minor point: the first "and the" doesn't belong. It's only "and the" for the second (and subsequent) criterion.

The minor point about text is already covered in a couple bugs, one being bug 57355.

back to gayatrib. my plate is full, gayatrib can you drive hewitt's patch in? any objections to this: 1) bake hewitt's patch. 2) if no issues with hewitt's patch, land it and my work around to mailWidgets.xml to the 0.9 branch. 3) land hewitt's patch on the trunk, but wait for the xul:deck fix from hyatt, instead of landing the work around to mailWidgets.xml

ok. i will do it. thanks for helping out on this Seth and Hewitt.

this should be p1, in my book.

ok, my hack is not needed. (see #77551) new patch coming, with the proper fix.

gayatri / hewitt, I've been baking hewitt's menulist part of this fix without problems. do you feel comfortable with me landing it when I land the rest of this patch?

go for it, seth

ooops, I had also created a patch with David Hyatt's suggestions... I should have updated the bug. I think it should be ok for you to land Hewitt's patch.

sr=bienvenu

r=hewitt

taking it back, I'll land my fix in a few minutes...

fixed (for laurel) and others.

OK using may01 commercial trunk build: linux rh6.2, mac OS 9.0. Assume win32 OK, too, although we don't yet have a working commercial build today.

I really think this is worth taking for 0.9. asa / blizzard what do you think?

a =asa@mozilla.org for checkin to 0.9 Thanks again Seth! Blizzard, can you check this in too. Thanks.

It's checked into the 0.9 branch now.