Closed
Bug 71982
Opened 24 years ago
Closed 24 years ago
External name sets should be driven by categories
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: dveditz, Assigned: jst)
References
Details
(Keywords: perf, Whiteboard: [XPCDOM])
Instead of making live code have to call AddExternalNameSet() in order to add
an object into the DOM namespace, this should be driven from a category using
the category manager. Then the component supporting the added object could stay
unloaded unless some content actually references the object.
XPInstall is an example of this: we load at startup for the sole purpose adding
our InstallTrigger NameSet, yet this is used by very, very few sites. How
often do you install things? x.themes.org uses it, the Netscape SmartUpdate
site uses it, mozdev.org uses it. But for any given user the xpinstall library
is loaded every time at startup, just in case that day they happen to go to one
of those sites.
I'm not suggesting we remove the current functionality, just supplement it.
Just guessing on the component, sorry if it's wrong.
Reporter | ||
Comment 1•24 years ago
|
||
I'm not sure if the perf keyword is appropriate, but it blocks a perf bug.
Assignee | ||
Comment 2•24 years ago
|
||
I will most likely fix this as part of making the JS engine access the DOM
through XPConnect, targetting for mozilla0.9.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Assignee | ||
Comment 3•24 years ago
|
||
Dan, could you pull the branch XPCDOM_20010329_BRANCH and see my fix on that
branch fixes this problem for xpinstall (and also test that xpinstall works).
There's also a ..._BASE tag if you wanto look at what I changed.
nsbeta1- since the bug that this is blocking is also nsbeta1-. Moving to the
next milestone since jst is not going to land the DOM conversion by 0.9.
jst: I have a tree, is there something I should try. Please contact me and help
me get started.
syd
Assignee | ||
Comment 6•24 years ago
|
||
I think we're ok with the testing here, the fix for this lives on the XPCDOM
branch and it'll land with the branch landing. I know the installer works on the
branch for doing things like installing plugins, and I also know that the other
categories of namesets works so I'm ok with checking this in as is.
Whiteboard: [XPCDOM]
Assignee | ||
Comment 7•24 years ago
|
||
Fixed by the xpcdom landing.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 9•23 years ago
|
||
according to johnny stenback comments i am marking this bug as verified
Status: RESOLVED → VERIFIED
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•