Closed
Bug 720353
Opened 13 years ago
Closed 13 years ago
Crash with abort message "xpcom_runtime_abort(###!!! ABORT: unknown union type: file /builds/slave/rel-m-beta-lnx-andrd-bld/build/obj-firefox/ipc/ipdl/PLayersChild.cpp, line 550)"
Categories
(Core :: Graphics, defect)
Tracking
()
People
(Reporter: scoobidiver, Unassigned)
References
Details
(Keywords: crash, topcrash, Whiteboard: [mobile-crash][native-crash])
Crash Data
Attachments
(1 file)
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
It's a new crash signature that first appeared in Fennec 10.0b5.
It's currently #1 top crasher in 10.0b5 with 70% (90/129) of all crashes.
Many stacks are buggy but it might be a Graphics or Layout bug.
In the Beta regression range:
http://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=69368d1fa5bf&tochange=11d741e4641c
it might be caused by bug 694964 or bug 715916.
The number of crashes caused by this bug (0.52 crash/ADU) is higher than the one fixed by bug 694964 (0.24 crash/ADU):
https://crash-stats.mozilla.com/daily?form_selection=by_version&p=Fennec&v[]=10.0b4&throttle[]=100.00&v[]=10.0b5&throttle[]=100.00&v[]=&throttle[]=100.00&v[]=&throttle[]=100.00&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-01-08&date_end=2012-01-24&submit=Generate
Frame Module Signature Source
0 libmozalloc.so mozalloc_abort memory/mozalloc/mozalloc_abort.cpp:66
1 libc.so __swrite
2 libxul.so libxul.so@0xe7cd58
3 libxul.so nsWSRunObject::DeleteChars editor/libeditor/html/nsWSRunObject.cpp:1607
4 @0x1
5 libxul.so _cairo_path_fixed_add gfx/cairo/cairo/src/cairo-path-fixed.c:775
6 libxul.so _cairo_path_fixed_move_to gfx/cairo/cairo/src/cairo-path-fixed.c:414
7 libxul.so _cairo_path_fixed_close_path gfx/cairo/cairo/src/cairo-path-fixed.c:659
8 libxul.so _moz_cairo_close_path gfx/cairo/cairo/src/cairo.c:2164
9 libxul.so _moz_cairo_rectangle gfx/cairo/cairo/src/cairo.c:2109
10 libxul.so gfxContext::Rectangle gfx/thebes/gfxContext.cpp:259
11 libxul.so gfxSurfaceDrawable::Draw gfx/thebes/gfxDrawable.cpp:181
12 @0x6
13 libmozutils.so malloc_mutex_unlock memory/jemalloc/jemalloc.c:1539
14 libmozutils.so arena_dalloc memory/jemalloc/jemalloc.c:4510
15 @0x2
16 libxul.so Pickle::WriteBytes ipc/chromium/src/base/pickle.cc:423
17 @0xbebbddea
18 libxul.so mozilla::layers::PLayersChild::Write obj-firefox/ipc/ipdl/PLayersChild.cpp:550
19 libxul.so mozilla::layers::PLayersChild::Write obj-firefox/ipc/ipdl/PLayersChild.cpp:1709
20 libxul.so mozilla::layers::PLayersChild::Write obj-firefox/ipc/ipdl/PLayersChild.cpp:635
21 libxul.so mozilla::layers::PLayersChild::Write obj-firefox/ipc/ipdl/PLayersChild.cpp:1048
22 libxul.so mozilla::layers::PLayersChild::Write obj-firefox/ipc/ipdl/PLayersChild.cpp:962
23 libxul.so mozilla::layers::PLayersChild::SendUpdate obj-firefox/ipc/ipdl/PLayersChild.cpp:156
24 libxul.so mozilla::layers::ShadowLayerForwarder::EndTransaction gfx/layers/ipc/ShadowLayers.cpp:324
25 libxul.so mozilla::layers::BasicShadowLayerManager::ForwardTransaction gfx/layers/basic/BasicLayers.cpp:3353
26 libxul.so mozilla::layers::BasicShadowLayerManager::EndTransaction gfx/layers/basic/BasicLayers.cpp:3328
27 libxul.so nsDisplayList::PaintForFrame layout/base/nsDisplayList.cpp:633
28 libxul.so nsDisplayList::PaintRoot layout/base/nsDisplayList.cpp:538
29 libxul.so nsLayoutUtils::PaintFrame layout/base/nsLayoutUtils.cpp:1700
30 libxul.so PresShell::Paint layout/base/nsPresShell.cpp:5475
31 libxul.so nsViewManager::RenderViews view/src/nsViewManager.cpp:415
32 libxul.so nsViewManager::Refresh view/src/nsViewManager.cpp:390
33 libxul.so nsViewManager::DispatchEvent view/src/nsViewManager.cpp:888
34 libxul.so HandleEvent view/src/nsView.cpp:159
35 libxul.so mozilla::widget::PuppetWidget::DispatchEvent widget/src/xpwidgets/PuppetWidget.cpp:320
36 libxul.so mozilla::widget::PuppetWidget::DispatchPaintEvent widget/src/xpwidgets/PuppetWidget.cpp:561
37 libxul.so mozilla::widget::PuppetWidget::PaintTask::Run widget/src/xpwidgets/PuppetWidget.cpp:601
38 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:631
39 libxul.so NS_ProcessNextEvent_P obj-firefox/xpcom/build/nsThreadUtils.cpp:245
...
Reporter | ||
Updated•13 years ago
|
Version: Trunk → Firefox 10
Comment 1•13 years ago
|
||
(In reply to Scoobidiver from comment #0)
> It's a new crash signature that first appeared in Fennec 10.0b5.
> It's currently #1 top crasher in 10.0b5 with 70% (90/129) of all crashes.
>
> Many stacks are buggy but it might be a Graphics or Layout bug.
> In the Beta regression range:
> http://hg.mozilla.org/releases/mozilla-beta/
> pushloghtml?fromchange=69368d1fa5bf&tochange=11d741e4641c
> it might be caused by bug 694964 or bug 715916.
In this regression range, Bug 694964 is the most likely cause.
> The number of crashes caused by this bug (0.52 crash/ADU) is higher than the
> one fixed by bug 694964 (0.24 crash/ADU):
In light of this, we should back out Bug 694964 from beta ASAP.
Blocks: 694964
Reporter | ||
Updated•13 years ago
|
Component: General → Graphics
Product: Fennec → Core
QA Contact: general → thebes
Target Milestone: --- → mozilla10
Version: Firefox 10 → 10 Branch
Comment 2•13 years ago
|
||
Bug 694964 has been backed out from Beta, which should fix this crash.
It has not been backed out from Aurora or m-c, so we should keep an eye out for this crash happening there.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Reporter | ||
Comment 3•13 years ago
|
||
There have been no crashes in Fennec 10.0b6.
Status: RESOLVED → VERIFIED
Comment 4•13 years ago
|
||
(In reply to Ali Juma [:ajuma] from comment #2)
> Bug 694964 has been backed out from Beta, which should fix this crash.
>
> It has not been backed out from Aurora or m-c, so we should keep an eye out
> for this crash happening there.
We've backed out bug 694964 from Beta 11 as well.
Reporter | ||
Updated•13 years ago
|
status-firefox10:
--- → fixed
status-firefox11:
--- → fixed
status-firefox12:
--- → affected
Target Milestone: mozilla10 → mozilla11
Reporter | ||
Comment 5•13 years ago
|
||
Let's reopen it as it's not fixed in XUL Fx 12 and above.
Status: VERIFIED → REOPENED
status-firefox12:
affected → ---
Resolution: FIXED → ---
Target Milestone: mozilla11 → ---
Comment 6•13 years ago
|
||
Not sure, but it looks like BasicShadowableThebesLayer::PaintBuffer called twice, and first time we set mBackBuffer = SurfaceDescriptor();
and second time we just abort here:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/basic/BasicLayers.cpp#2374
Comment 7•13 years ago
|
||
btw, do we have syslog output for this crash or something like that, if there are "should have a back buffer by now" message, then my assumption is correct and we have to do something with that abort...
Reporter | ||
Comment 8•13 years ago
|
||
The back buffer log is in 11.0 but there are only 9 ADU in FennecAndroid 11.0b1 and 0 ADU in XUL Fennec 11.0b1 so far and nobody hit that crash.
Updated•13 years ago
|
tracking-fennec: ? → ---
Comment 9•13 years ago
|
||
Ok, I took current beta 11, applied patches from 694964, and cannot reproduce this crash.
And IIUC crash happening on IPDL attempt to process thebesLayer Swap transaction, which means that we already passed http://mxr.mozilla.org/mozilla-central/source/gfx/layers/basic/BasicLayers.cpp#2374 - surface check point, and that is possible only in next chain
1) BasicShadowableThebesLayer::PaintBuffer - > thebesPaint pushed into transactions array and related buffer assigned to mROFrontBuffer
2) BasicShadowableThebesLayer::SetBackBufferAndAttrs call came from previous transaction. and drop last reference to buffer which is in pending transactions queue by mROFrontBuffer = aReadOnlyFrontBuffer.
3) Result SendUpdate has transaction with ThebesSwap and invalid buffer
Comment 10•13 years ago
|
||
I think we should modify fix for bug 694964, and Hold reference to buffer which is pending transaction queue in different variable and do not use mROFrontBuffer
Reporter | ||
Updated•13 years ago
|
Crash Signature: org.mozilla.firefox_beta-2.apk@0xfda11f]
[@ mozalloc_abort | __swrite | libxul.so@0xe7cd58 | org.mozilla.firefox_beta-1.apk@0x108c11f] → org.mozilla.firefox_beta-2.apk@0xfda11f]
[@ mozalloc_abort | __swrite | libxul.so@0xe7cd58 | org.mozilla.firefox_beta-1.apk@0x108c11f]
[@ TouchBadMemory]
status-firefox14:
--- → affected
Depends on: 722044
Whiteboard: [mobile-crash] → [mobile-crash][native-crash]
Reporter | ||
Updated•13 years ago
|
Crash Signature: org.mozilla.firefox_beta-2.apk@0xfda11f]
[@ mozalloc_abort | __swrite | libxul.so@0xe7cd58 | org.mozilla.firefox_beta-1.apk@0x108c11f]
[@ TouchBadMemory] → org.mozilla.firefox_beta-2.apk@0xfda11f]
[@ mozalloc_abort | __swrite | libxul.so@0xe7cd58 | org.mozilla.firefox_beta-1.apk@0x108c11f]
[@ TouchBadMemory]
[@ TouchBadMemory | mozalloc_abort | dalvik-heap @0x11f911f]
[@ TouchBadMemory | mozalloc_abort …
Comment 11•13 years ago
|
||
I'm sometimes running into this now on Native Fennec. We should back out bug 694964 from m-c.
Comment 12•13 years ago
|
||
Updated•13 years ago
|
Attachment #607302 -
Flags: review?(bgirard)
Updated•13 years ago
|
Attachment #607302 -
Flags: review?(bgirard) → review+
Comment 13•13 years ago
|
||
Comment 14•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Version: 10 Branch → Trunk
Updated•13 years ago
|
status-firefox12:
--- → affected
status-firefox13:
--- → affected
Comment 15•13 years ago
|
||
This is presumably still affecting FF10 XUL Fennec builds (10.0.3 was pushed to the market on 3/13). Can we uplift the fix to the ESR, from which XUL Fennec is building for releases?
If we think this affects Fennec Native as well, we should also uplift to Aurora 13.
status-firefox-esr10:
--- → affected
tracking-firefox-esr10:
--- → 12+
Comment 16•13 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #15)
> This is presumably still affecting FF10 XUL Fennec builds (10.0.3 was pushed
> to the market on 3/13). Can we uplift the fix to the ESR, from which XUL
> Fennec is building for releases?
Bug 694964 was backed out of FF10 on Jan. 23 (see Comment 2 above), so this crash shouldn't be happening there.
> If we think this affects Fennec Native as well, we should also uplift to
> Aurora 13.
Yes, this affects Fennec Native with off-main-thread compositing, so we should indeed uplift this when off-main-thread compositing gets uplifted.
Updated•13 years ago
|
tracking-firefox-esr10:
12+ → ---
tracking-firefox13:
--- → +
Reporter | ||
Updated•13 years ago
|
Crash Signature: TouchBadMemory | mozalloc_abort | libskia.so@0x74ffe]
[@ TouchBadMemory | mozalloc_abort | system@framework@ext.jar@classes.dex@0x26d] → TouchBadMemory | mozalloc_abort | libskia.so@0x74ffe]
[@ TouchBadMemory | mozalloc_abort | system@framework@ext.jar@classes.dex@0x26d]
[@ TouchBadMemory | mozalloc_abort]
Reporter | ||
Updated•13 years ago
|
Crash Signature: | dalvik-heap @0x11f111f]
[@ TouchBadMemory | mozalloc_abort | _moz_cairo_set_source_rgba]
[@ TouchBadMemory | mozalloc_abort | system@framework@ext.jar@classes.dex@0x26d]
[@ TouchBadMemory | mozalloc_abort | ashmem (deleted)@0x23ff40]
[@ TouchBadMemo… → | dalvik-heap @0x11f111f]
[@ TouchBadMemory | mozalloc_abort | _moz_cairo_set_source_rgba]
[@ TouchBadMemory | mozalloc_abort | _moz_cairo_curve_to]
[@ TouchBadMemory | mozalloc_abort | system@framework@ext.jar@classes.dex@0x26d]
[@ TouchBadMemory | m…
Reporter | ||
Updated•13 years ago
|
Crash Signature: TouchBadMemory | mozalloc_abort | mozilla::image::RasterImage::Draw]
[@ TouchBadMemory | mozalloc_abort | nsCOMPtr_base::~nsCOMPtr_base | ImageRenderer::~ImageRenderer] → TouchBadMemory | mozalloc_abort | mozilla::image::RasterImage::Draw]
[@ TouchBadMemory | mozalloc_abort | nsCOMPtr_base::~nsCOMPtr_base | ImageRenderer::~ImageRenderer]
[@ TouchBadMemory | mozalloc_abort | DeleteRangeTxn::DoTransaction]
Reporter | ||
Updated•13 years ago
|
Crash Signature: TouchBadMemory | mozalloc_abort | mozilla::image::RasterImage::Draw]
[@ TouchBadMemory | mozalloc_abort | nsCOMPtr_base::~nsCOMPtr_base | ImageRenderer::~ImageRenderer]
[@ TouchBadMemory | mozalloc_abort | DeleteRangeTxn::DoTransaction] → TouchBadMemory | mozalloc_abort | mozilla::image::RasterImage::Draw]
[@ TouchBadMemory | mozalloc_abort | nsCOMPtr_base::~nsCOMPtr_base | ImageRenderer::~ImageRenderer]
[@ TouchBadMemory | mozalloc_abort | DeleteRangeTxn::DoTransaction]
[@ TouchBadMemo…
Reporter | ||
Comment 17•13 years ago
|
||
(In reply to Ali Juma [:ajuma] from comment #16)
> Bug 694964 was backed out of FF10 on Jan. 23 (see Comment 2 above), so this
> crash shouldn't be happening there.
Crash Signature: TouchBadMemory | mozalloc_abort | DeleteRangeTxn::CreateTxnsToDeleteNodesBetween] → TouchBadMemory | mozalloc_abort | DeleteRangeTxn::CreateTxnsToDeleteNodesBetween]
[@ TouchBadMemory | mozalloc_abort | nsHtml5ElementName::releaseStatics]
[@ TouchBadMemory | mozalloc_abort | pixman_region16_copy_from_region32]
[@ TouchBadMemory | moza…
Comment 18•13 years ago
|
||
No need to track for FF13 at this point - we don't expect to ship a Fennec build off of that version.
Comment 19•13 years ago
|
||
"TouchBadMemory | mozalloc_abort | nsHtml5ElementName::releaseStatics" is currently roughly half of our Fennec 13 Beta crashes, if this is this bug, is there any chance to get the fix uplifted to beta?
Reporter | ||
Updated•13 years ago
|
Crash Signature: mozalloc_abort | PR_GetThreadPrivate | libxul.so@0xf7d93f | nsHtml5ElementName::releaseStatics] → mozalloc_abort | PR_GetThreadPrivate | libxul.so@0xf7d93f | nsHtml5ElementName::releaseStatics]
[@ TouchBadMemory | mozalloc_abort | pixman_region32_copy_from_region16]
[@ TouchBadMemory | mozalloc_abort | PR_GetThreadPrivate | libxul.so@0xf7dacb | nsHt…
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•