build id: 1999052517 platform: windows 98 although the file | open dialog box is vastly improved now, there are two small issues with it: 1) the title of the dialog should probably be changed to "Open Page" for 4.x consistency 2) although the text reads "Use the Choose File… button", the button itself is labeled "Select File…". choose one or the other... :)

Scratch that thought - how about "Open File or Location" instead?

Reassign it to don for final clean-up later. cc german for final design decision and spec update.

Bill, is this our bug or an XP Toolkit issue?

No, this one is definitely ours. I'll determine what the proper UI look is to be and make it so. I've purposely designed all the dialogs I've done to be as ugly as possible. I'm hoping all the effort we're expending to make the UI defined via html and css enables more qualified individuals to make them pretty. This engineer would rather just write code. Heck, I think it might be a good idea for the QA people to just go in and fix stuff like this; they can do just as good a job as I can, probably better.

re-assigning to German. German, if you can't get CVS up and running to check in the fix yourself, just tell me what to do and I'll check it in.

I have updated the XUL file. I somebody could pls also update the menu item to "Open File or Location..." and dialog title to "Open File or Location". Enclosing XUL file shortly

I added the dialog title, changed the menu text in navigator.xul, and checked this all in.

VERIFIED fixed for all platforms as of 1999070708 builds

I'm considering reopening this bug as the text in the dialog box itself may not be correct (German? Feedback please?). It currently reads: "Enter the World Wide Web location (URL) you would like to open. Use the Choose File… button to select a local file:" Grammatically speaking, this isn't ideal as it seems to give two commands in a row: type in a URL, and then use the Choose File button. This is bad. The text should probably read as follows: "Enter the World Wide Web location (URL) or specify the local file you would like to open."

I agree, mostly. What we have is less than optimal and since it will have to get fixed one day it might as well be now my proposal: Change Enter the World Wide Web location (URL) you would like to open. Use the Choose File… button to select a local file: To Enter the World Wide Web location (URL) you would like to open or use the Choose File… button to select a local file: just change the (.) to an ( or )

Clearing Fixed resolution since this is now re-opened.

OK. I've requested approval for checkin of this change: Index: openLocation.xul =================================================================== RCS file: /cvsroot/mozilla/xpfe/browser/src/openLocation.xul,v retrieving revision 1.6 diff -r1.6 openLocation.xul 24c24 < <html:div style="width: 100%;">Enter the World Wide Web location (URL) you would like to open. </html:div><html:div style="width: 100%; margin-bottom: 0.5em;">Use the Choose File... button to select a local file:</html:div> --- > <html:div style="width: 100%;">Enter the World Wide Web location (URL) you would like to open or </html:div><html:div style="width: 100%; margin-bottom: 0.5em;">use the Choose File... button to select a local file:</html:div >

it looks like you're missing a ">" on the last line of your replacement diff. or am i just nutty?

marking VERIFIED for 1999070910 builds on all platforms.