Closed Bug 72110 Opened 24 years ago Closed 24 years ago

Directory Viewer Timer Priority may be too low

Categories

(SeaMonkey :: General, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

Currently the timers in the directory viewer are set to NS_PRIORITY_LOWEST. I have been playing with these settings and I am finding the performance is alot better when these timers are set to be normal prority. Chris, could you review this change?
bugzilla is not liking attachments at the moment.... Index: nsDirectoryViewer.cpp =================================================================== RCS file: /cvsroot/mozilla/xpfe/components/directory/nsDirectoryViewer.cpp,v retrieving revision 1.66 diff -u -r1.66 nsDirectoryViewer.cpp --- nsDirectoryViewer.cpp 2001/03/14 02:39:00 1.66 +++ nsDirectoryViewer.cpp 2001/03/15 22:00:11 @@ -1337,8 +1337,7 @@ NS_ASSERTION(NS_SUCCEEDED(rv), "unable to create a timer"); if (NS_SUCCEEDED(rv)) { - mTimer->Init(nsHTTPIndex::FireTimer, this, 1, - NS_PRIORITY_LOWEST, NS_TYPE_ONE_SHOT); + mTimer->Init(nsHTTPIndex::FireTimer, this, 10); // Note: don't addref "this" as we'll cancel the // timer in the httpIndex destructor } @@ -1374,8 +1373,7 @@ NS_ASSERTION(NS_SUCCEEDED(rv), "unable to create a timer"); if (NS_FAILED(rv)) return(rv); - mTimer->Init(nsHTTPIndex::FireTimer, this, 1, - NS_PRIORITY_LOWEST, NS_TYPE_ONE_SHOT); + mTimer->Init(nsHTTPIndex::FireTimer, this, 10); // Note: don't addref "this" as we'll cancel the // timer in the httpIndex destructor } @@ -1516,8 +1514,7 @@ httpIndex->mTimer = do_CreateInstance("@mozilla.org/timer;1"); if (httpIndex->mTimer) { - httpIndex->mTimer->Init(nsHTTPIndex::FireTimer, aClosure, 10, - NS_PRIORITY_LOWEST, NS_TYPE_ONE_SHOT); + httpIndex->mTimer->Init(nsHTTPIndex::FireTimer, aClosure, 10); // Note: don't addref "this" as we'll cancel the // timer in the httpIndex destructor }
(my cache setting was set to NEVER check the network. With this set, you can't post... )
sure, r=waterson
Actually, I am working this another direction..... I only want the directory viewer to hold open one (1) network request. When I land this change, the timer's really don't matter as much. Marking WONTFIX
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: