Closed
Bug 721579
Opened 13 years ago
Closed 13 years ago
Remove rt->gcTriggerBytes and rt->gcLastBytes
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
These fields are now used in only one place: a weird case in TriggerCompartmentGC that I've never seen get used. I added the code a long time ago when I was worried that we might get into a situation where full GCs were never happening. I don't think we have to worry about that, though :-(.
Attachment #591991 -
Flags: review?(igor)
|
Assignee | |
Updated•13 years ago
|
Blocks: IncrementalGC
|
||
Comment 1•13 years ago
|
||
Comment on attachment 591991 [details] [diff] [review]
patch
Review of attachment 591991 [details] [diff] [review]:
-----------------------------------------------------------------
Reducing unnecessary complexity of our GC heuristics is really nice!
Attachment #591991 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla13
|
||
Comment 3•13 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/71f5bf4df2f6 - one of the six in that push was crashing in js::gc::Mark<JSString>
Target Milestone: mozilla13 → ---
|
|
Assignee | |
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla13
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•