Closed Bug 7216 Opened 25 years ago Closed 25 years ago

MLK: CObserverDictionary related?

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: bruce, Assigned: rickg)

Details

Build from May 26, 1999. Solaris 2.6. Start and immediately exit apprunner -editor and this leaks. MLK: 16 bytes leaked at 0x5a2038 * This memory was allocated from: malloc [rtlib.o] __bUiLtIn_nEw [libgcc.a] __builtin_new [rtlib.o] nsSupportsArray::Enumerate(nsIEnumerator**) [nsSupportsArray.cpp:356] nsObserverList::EnumerateObserverList(nsIEnumerator**) [nsObserverList.cpp:131] nsObserverService::EnumerateObserverList(nsIEnumerator**,nsString*) [nsObserverService.cpp:207] CObserverDictionary::RegisterObservers() [nsDTDUtils.cpp:681] CObserverDictionary::CObserverDictionary() [nsDTDUtils.cpp:642] CNavDTD::WillHandleStartTag(CToken*,nsHTMLTag,nsCParserNode&) [CNavDTD.cpp:1190] CNavDTD::HandleStartToken(CToken*) [CNavDTD.cpp:1402] NavDispatchTokenHandler(CToken*,nsIDTD*) [CNavDTD.cpp:249] CTokenHandler::operator ()(CToken*,nsIDTD*) [nsTokenHandler.cpp:80] CNavDTD::HandleToken(CToken*,nsIParser*) [CNavDTD.cpp:682] CNavDTD::BuildModel(nsIParser*,nsITokenizer*,nsITokenObserver*,nsIContentSink*) [CNavDTD.cpp:514] nsParser::BuildModel() [nsParser.cpp:844] nsParser::ResumeParse(nsIDTD*) [nsParser.cpp:792] nsParser::OnDataAvailable(nsIURL*,nsIInputStream*,unsigned int) [nsParser.cpp:1011] nsDocumentBindInfo::OnDataAvailable(nsIURL*,nsIInputStream*,unsigned int) [nsDocLoader.cpp:1502] stub_put_block(_NET_StreamClass*,const char*,int) [nsStubContext.cpp:834] net_output_about_url [mkabout.c:677] net_AboutLoad [mkabout.c:913] NET_GetURL [mkgeturl.c:2979] net_release_urls_for_processing [mkgeturl.c:1338] net_CheckForWaitingURL [mkgeturl.c:1401] NET_ProcessNet [mkgeturl.c:3486] NET_PollSockets [mkselect.c:298] nsNetlibService::NetPollSocketsCallback(nsITimer*,void*) [nsNetService.cpp:1276] TimerImpl::FireTimeout() [nsTimer.cpp:73] nsTimerExpired [nsTimer.cpp:189] g_timeout_dispatch [gmain.c:1147]
Assignee: kostello → kin
Target Milestone: M8
Kin, could you verify that this is still happening now that the editor is beng properly cleaned up.
Accepting bug.
Status: NEW → ASSIGNED
I don't think this is editor related, it actually looks like a parser leak. Simon and I spent some time last week fixing all editor related leaks, and we do release the editor and it's components, if we are notified that we are shutting down. To see this leak, you have to shutdown via File->Quit. It does not show up if you close via the windows close button. Cc'ing rickg@netscape.com.
I believe you mean the reverse? Exiting via File->Quit doesn't free up the webshells and a lot of things leak. Exiting via the window manager functionality frees up a lot of things correctly. The other editor leaks had all been found by exiting via the window manager.
Right, I was saying that we don't leak the editor if we are notified that we are shutting down. Right now, the editor appcore only gets notified if someone hits the close button on the window frame. The leak reported in this bug only shows up when you shutdown via the File->Quit menu item. For some reason no one is notified that we are shutting down when using the Quit menu item.
Assignee: kin → rickg
Status: ASSIGNED → NEW
Assigning to rickg@netscape.com
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
I doubled checked the observer in both cases mentioned, and it doesn't leak in either case. Bruce -- can you verify this under purify?
Kin, can you mark this one VERIFIED ? thanks!
I'd prefer that this wait until it is verified. With luck, my schedule here at work will lighten up so I can get a bunch of bug verifications done next week.
we need to get this bug off the verification radar...Bruce, any spare time this week?
QA Contact: sujay → bruce
changing qa_contact to bruce@cybersight.com
marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.