Closed
Bug 723221
Opened 13 years ago
Closed 13 years ago
Properly premultiply during JPG encode/decode
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Parent bug is Bug 713143.
|
Assignee | |
Comment 1•13 years ago
|
||
Clean try run at: https://tbpl.mozilla.org/?tree=Try&rev=334cf17cf17e
Attachment #593537 -
Flags: review?(joe)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 593537 [details] [diff] [review]
Premultiply JPG data correctly
Review of attachment 593537 [details] [diff] [review]:
-----------------------------------------------------------------
This is fine; I presume you decided not to use GFX_PREMULTIPLY because you're unifying all (un)premultiplication in a separate bug?
Attachment #593537 -
Flags: review?(joe) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
I forgot that gfxColor.h had an individual GFX_PREMULTIPLY. It's a worse approximation, but at least it's consistent.
Changed that and pushed back to try. Carrying forward r+ unless the trypush collapses.
https://tbpl.mozilla.org/?tree=Try&rev=029660d930a6
Attachment #593537 -
Attachment is obsolete: true
Attachment #595577 -
Flags: review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla13
|
|
Assignee | |
Comment 5•13 years ago
|
||
Looks like this got skipped over:
https://hg.mozilla.org/mozilla-central/rev/308b3ced990b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•