Closed Bug 73415 Opened 24 years ago Closed 24 years ago

Unable to open news attachments

Categories

(MailNews Core :: Networking: NNTP, defect, P2)

x86
Windows 2000
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9

People

(Reporter: mscott, Assigned: mscott)

References

Details

(Keywords: crash)

Attachments

(2 files)

Sometime during the perf landing i think we broke the ability to open news attachments. Libmime passes a URL and a RDF URI for the currently displayed message into msgHdrViewOverlay which in turn passes that into nsIMsgMessageService::OpenAttachment. OpenAttachment uses the RDF URI to get useful pieces of information in order to fetch the attachment part. For news the RDF URI is now the same as the protocol URL. At least it's the same when libmime gives it to us. This still works for imap and local so we must have done something to news to break this.
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9
this first patch is needed so we automatically extract the part using a mime converter when fetching an attachment.
RDF URI for attachments? do you mean something like news_message://news.mozilla.org/netscape.test#1?part=1.1 when we display news_message://news.mozilla.org/netscape.test#1, we remember that original uri (*), and then convert it to a news://host/message-id url and run that. (*) we remember the original uri because we want to know the group and article number, so we do "GROUP" (if necessary), "ARTICLE number" instead of asking for the message by message id, which is slower. so for attachments, we'd want to do something similar news_message://news.mozilla.org/netscape.test#1?part=1.1 would get turned into news://news.mozilla.org/message-id?part=1.1 is that not happening? news://host/message-id?part=x urls should find the part in the cache (since the message cache does the lookup by url, stopping at the "?") this is how news message display (with attachments) currently works. let me know if you want me to help.
I should have added: sorry for busting this. a couple other comments: when I landed, I was able to view messages with attachemd images and view the attached images in the browser window. on my local build (with libpr0n enabled) I seem to get into an inifinte loop when loading news messages with attachments. is that convered by another bug?
heh, no that's covered in this bug! =). See the patch I attached to this bug which gets us past the infinite loop. but opening the attachment is still busted because the RDF URI passed to OpenAttachment is not correct. We attempt to decompose the uri to get the news folder and message key; however we fail miserably here and are unable to get this information. So we bail out. maybe the fix is as easy as having libmime get the original URI instead of the current RDF URI for the currently displayed news message and to use that when it passes out the URI to OpenAttachment.
posting the fix for everything: 1) a race condition in Cleanup url where we were clearing the busy flag to early 2) in mime, if we are looking at a news attachment, get the RDF URI from the OriginalSpec stored on the news url instead of by calling nsIMsgMailNewsUrl::GetURIForURL 3) The usual stuff I've already done for local and imap to automatically invoke a stream converter when fetching a part. You can now open and save news attachments from the message pane.
sr=bienvenu
*** Bug 73485 has been marked as a duplicate of this bug. ***
*** Bug 73738 has been marked as a duplicate of this bug. ***
Keywords: crash
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
*** Bug 72414 has been marked as a duplicate of this bug. ***
verified, I tested this opening a .gif file attached to a news msg and the message noted in dup bug 73738 tested on mac, linux and winme using 2001-04-03
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: