Closed
Bug 73650
Opened 24 years ago
Closed 24 years ago
CTIME incorrectly defined in portable.h on IRIX6.5, breaking build
Categories
(Directory :: LDAP C SDK, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jayvdb, Assigned: mhein)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
When building c-sdk on IRIX6.5, CTIME gets incorrectly defined in portable.h
IRIX6_2 & IRIX6_3 are catered for on line 270, and IRIX 6.5 syntax is the same.
http://lxr.mozilla.org/mozilla/source/directory/c-
sdk/ldap/include/portable.h#270
---
cc -o request.o -c -fullwarn -xansi -multigot -n32 -woff 1209 -mips3 -g -
UNDEBUG -DUSE_AUTOCONF=1 -DDEBUG=1 -DDEBUG_johnv=1 -DXP_UNIX=1 -DIRIX=1 -
DSVR4=1 -D_SGI_MP_SOURCE=1 -D_PR_HAVE_GETPROTO_R=1 -
D_PR_HAVE_GETPROTO_R_POINTER=1 -D_PR_HAVE_SGI_PRDA_PROCMASK=1 -DHAVE_LCHOWN=1 -
DHAVE_STRERROR=1 -D_REENTRANT=1 -DFORCE_PR_LOG -D_PR_PTHREADS -
UHAVE_CVAR_BUILT_ON_SEM -DUSE_WAITPID -DNEEDPROTOS -DLDAP_DEBUG -
DLDAP_REFERRALS -DLDAP_LDBM -DLDAP_SHELL -DLDAP_PASSWD -DLDBM_USE_NDBM -
DLDAP_SSLIO_HOOKS -DFILTERFILE=./ldapfilter.conf -
DTEMPLATEFILE=./ldaptemplates.conf -DNDEBUG -UMOZILLA_CLIENT -
I/projects/sise/mozilla/devel/workpits/moz/latest_feature/mozilla/directory/c-
sdk/ldap/include -
I../../include /projects/sise/mozilla/devel/workpits/moz/latest_feature/mozill
a/directory/c-sdk/ldap/libraries/libldap/request.c
...
cc-1136 cc: ERROR File
= /projects/sise/mozilla/devel/workpits/moz/latest_feature/mozilla/directory/c-
sdk/ldap/libraries/libldap/request.c, Line = 665
Too many arguments in function call.
CTIME( (time_t *) &lc->lconn_lastused, buf, sizeof(buf) ));
^
...
1 error detected in the compilation
of "/projects/sise/mozilla/devel/workpits/moz/latest_feature/mozilla/directory/c
-sdk/ldap/libraries/libldap/request.c".
gmake[3]: *** [request.o] Error 2
---
Reporter | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
The patch looks correct to me, so the module owner approves. Michael, I am
reassigning this to you so you can commit on the appropriate branches, etc.
Assignee: mcs → mhein
QA Contact: __UNKNOWN__
Reporter | ||
Comment 3•24 years ago
|
||
I have built mozilla with --enable-ldap & --enable-ldap-experimental, however I
can only see one means of testing it; via the URL bar, which works. Are there
any others?
Reporter | ||
Comment 4•24 years ago
|
||
I have tested the modified change that eventually hit the tree, and it works in
latest and 0.9
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•