Closed Bug 73801 Opened 24 years ago Closed 21 years ago

Need to disable the Delete button & menu item Delete Address Book when PAB or CAB is selected

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.6beta

People

(Reporter: jglick, Assigned: stephend)

References

Details

(Whiteboard: [adt3][ue2])

Attachments

(3 files, 3 obsolete files)

In the AB, select either the Personal Address Book or Collected AB. Click "Delete". The error dialog appears: Text: "You are not allowed to delete the Personal and Collected Addresses address books. Please deselect them for your delete operation". Title: "Personal and Collected address books cannot be deleted" Dialog Title needs correct capitalization and is a little wordy(Capitalize all words, except articles, conjunctions and prepositions. Articles, conjunctions and prepositions should be capitalized if they are at the beginning of a Dialog or Window Title). Text could us some re-wording. Robin, please suggest correct wording, title and capitalization and then reassign back to default owner.
Attached image screenshot of current dialog (deleted) —
QA Contact: esther → fenella
Scott, Candice - can we dim the Delete button and the Edit>Delete Address Book menu item in the AB window when the user has selected either the PAB or the CAB? If we can't/won't do that, I can supply re-worded error message text.
disabling would probably be the best way to go.
Agree. If the CAB feature is turned off, can the user delete the CAB?
QA Contact: fenella → nbaca
Trunk build 2002-02-26-3: WinMe The Delete button is till enabled if the PAB or CAB is selected. After trying to either one of these address books then it reports "You are not allowed to delete the Personal or Collected Addresses address books". Note: After disabling the CAB feature, the Delete button is still enabled if the CAB is selected.
Reassigning to default owner, since we agree this requires an engineering change (disabling Delete button when CAB or PAB is selected) rather than an error message. Nominating for Mach V.
Assignee: robinf → racham
Keywords: nsbeta1
Discussed in 2/28/02 Mail & News bug meeting. Decisions was to minus this bug.
Keywords: nsbeta1nsbeta1-
Target Milestone: --- → mozilla1.2
Per Bug triage, Changing summary to reflect the morfing of this bug. Old Summary "Error dialog when attempting to delete the CAB or PAB needs polish" New Summary "Need to disable the Delete button & menu item Delete Address Book when PAB or CAB is selected"
Summary: Error dialog when attempting to delete the CAB or PAB needs polish → Need to disable the Delete button & menu item Delete Address Book when PAB or CAB is selected
Blocks: 156960
Keywords: nsbeta1-nsbeta1
Whiteboard: [ue2]
Mail triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: [ue2] → [adt3][ue2]
Reassigning.
Assignee: racham → shliang
Target Milestone: mozilla1.2alpha → mozilla1.4beta
Attached patch Fix the delete key/menu/button only (obsolete) (deleted) — Splinter Review
In other words, this patch should make the dialog unnecessary.
This patch removes: * cannotDeleteMessage from addressBook.properties * unnecessary checks for the PAB/CAB in AbDeleteDirectory (since we now disable the menu items and therefore don't call this function all all for those types) * brings the whitespace to 2-character spacing, which seems to be the prevalent style in the rest of this file
Attachment #135034 - Flags: superreview?(bienvenu)
Attachment #135034 - Flags: review?(neil.parkwaycc.co.uk)
combine these statements + if (selectedDir == kPersonalAddressbookURI) + return false; + if (selectedDir == kCollectedAddressbookURI) + return false; into: if (selectedDir == kPersonalAddressbookURI || selectedDir == kCollectedAddressbookURI) return false; + if (parentRow == -1) + parentId = "moz-abdirectory://"; + else + parentId = dirTree.builderView.getResourceAtIndex(parentRow).Value; parentId = (parentRow == -1) ? "moz-abdirectory://" : dirTree.builderView.getResourceAtIndex(parentRow).Value; this can also be simplified: + if (directory.isMailList) + confirmDeleteMessage = gAddressBookBundle.getString("confirmDeleteMailingList"); + else + confirmDeleteMessage = + confirmDeleteMessage = gAddressBookBundle.getString(directory.isMailList ? "confirmDeleteMailingList" : "confirmDeleteAddressbook");
Attachment #135034 - Attachment is obsolete: true
Attachment #135035 - Attachment is obsolete: true
Attachment #135034 - Flags: superreview?(bienvenu)
Attachment #135034 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 135143 [details] [diff] [review] Incorporates David's style comments David / Neil, do either of you want to see the final diff -uw?
Attachment #135143 - Flags: superreview?
Attachment #135143 - Flags: review?
Comment on attachment 135143 [details] [diff] [review] Incorporates David's style comments David / Neil, do either of you want to see the final diff -uw?
Attachment #135143 - Flags: superreview?(bienvenu)
Attachment #135143 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #135143 - Flags: superreview?
Attachment #135143 - Flags: review?
Sorry, I meant a diff WITH the whitespace changes, which would just of course be a regular unified diff without the -w switch.
Assignee: shliang → stephendonner
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: mozilla1.4beta → mozilla1.6beta
Comment on attachment 135143 [details] [diff] [review] Incorporates David's style comments I prefer to review a non-w diff because that saves me the trouble of backing out the patch afterwards ;-)
Attachment #135143 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #135143 - Flags: superreview?(bienvenu) → superreview+
Fixed! Thanks for the original patch, Neil!
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
*** Bug 196123 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: