Closed
Bug 73801
Opened 24 years ago
Closed 21 years ago
Need to disable the Delete button & menu item Delete Address Book when PAB or CAB is selected
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.6beta
People
(Reporter: jglick, Assigned: stephend)
References
Details
(Whiteboard: [adt3][ue2])
Attachments
(3 files, 3 obsolete files)
(deleted),
image/gif
|
Details | |
(deleted),
patch
|
neil
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
In the AB, select either the Personal Address Book or Collected AB. Click
"Delete". The error dialog appears:
Text: "You are not allowed to delete the Personal and Collected Addresses
address books. Please deselect them for your delete operation".
Title: "Personal and Collected address books cannot be deleted"
Dialog Title needs correct capitalization and is a little wordy(Capitalize all
words, except articles, conjunctions and prepositions. Articles, conjunctions
and prepositions should be capitalized if they are at the beginning of a Dialog
or Window Title).
Text could us some re-wording.
Robin, please suggest correct wording, title and capitalization and then
reassign back to default owner.
Scott, Candice - can we dim the Delete button and the Edit>Delete Address Book
menu item in the AB window when the user has selected either the PAB or the CAB?
If we can't/won't do that, I can supply re-worded error message text.
Comment 3•24 years ago
|
||
disabling would probably be the best way to go.
Agree. If the CAB feature is turned off, can the user delete the CAB?
Comment 5•23 years ago
|
||
Trunk build 2002-02-26-3: WinMe
The Delete button is till enabled if the PAB or CAB is selected. After trying to
either one of these address books then it reports
"You are not allowed to delete the Personal or Collected Addresses address
books".
Note: After disabling the CAB feature, the Delete button is still enabled if the
CAB is selected.
Reassigning to default owner, since we agree this requires an engineering change
(disabling Delete button when CAB or PAB is selected) rather than an error
message. Nominating for Mach V.
Assignee: robinf → racham
Keywords: nsbeta1
Comment 7•23 years ago
|
||
Discussed in 2/28/02 Mail & News bug meeting. Decisions was to minus this bug.
Per Bug triage, Changing summary to reflect the morfing of this bug.
Old Summary "Error dialog when attempting to delete the CAB or PAB needs polish"
New Summary "Need to disable the Delete button & menu item Delete Address Book
when PAB or CAB is selected"
Summary: Error dialog when attempting to delete the CAB or PAB needs polish → Need to disable the Delete button & menu item Delete Address Book when PAB or CAB is selected
Comment 9•22 years ago
|
||
Mail triage team: nsbeta1+/adt3
Comment 11•21 years ago
|
||
In other words, this patch should make the dialog unnecessary.
Assignee | ||
Comment 12•21 years ago
|
||
This patch removes:
* cannotDeleteMessage from addressBook.properties
* unnecessary checks for the PAB/CAB in AbDeleteDirectory (since we now disable
the menu items and therefore don't call this function all all for those types)
* brings the whitespace to 2-character spacing, which seems to be the prevalent
style in the rest of this file
Assignee | ||
Comment 13•21 years ago
|
||
Attachment #135024 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #135034 -
Flags: superreview?(bienvenu)
Attachment #135034 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 14•21 years ago
|
||
combine these statements
+ if (selectedDir == kPersonalAddressbookURI)
+ return false;
+ if (selectedDir == kCollectedAddressbookURI)
+ return false;
into:
if (selectedDir == kPersonalAddressbookURI || selectedDir ==
kCollectedAddressbookURI)
return false;
+ if (parentRow == -1)
+ parentId = "moz-abdirectory://";
+ else
+ parentId = dirTree.builderView.getResourceAtIndex(parentRow).Value;
parentId = (parentRow == -1) ? "moz-abdirectory://" :
dirTree.builderView.getResourceAtIndex(parentRow).Value;
this can also be simplified:
+ if (directory.isMailList)
+ confirmDeleteMessage =
gAddressBookBundle.getString("confirmDeleteMailingList");
+ else
+ confirmDeleteMessage =
+ confirmDeleteMessage = gAddressBookBundle.getString(directory.isMailList ?
"confirmDeleteMailingList" : "confirmDeleteAddressbook");
Attachment #135034 -
Attachment is obsolete: true
Attachment #135035 -
Attachment is obsolete: true
Attachment #135034 -
Flags: superreview?(bienvenu)
Attachment #135034 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 16•21 years ago
|
||
Comment on attachment 135143 [details] [diff] [review]
Incorporates David's style comments
David / Neil, do either of you want to see the final diff -uw?
Attachment #135143 -
Flags: superreview?
Attachment #135143 -
Flags: review?
Assignee | ||
Comment 17•21 years ago
|
||
Comment on attachment 135143 [details] [diff] [review]
Incorporates David's style comments
David / Neil, do either of you want to see the final diff -uw?
Attachment #135143 -
Flags: superreview?(bienvenu)
Attachment #135143 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Updated•21 years ago
|
Attachment #135143 -
Flags: superreview?
Attachment #135143 -
Flags: review?
Assignee | ||
Comment 18•21 years ago
|
||
Sorry, I meant a diff WITH the whitespace changes, which would just of course be
a regular unified diff without the -w switch.
Assignee: shliang → stephendonner
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: mozilla1.4beta → mozilla1.6beta
Comment 19•21 years ago
|
||
Comment on attachment 135143 [details] [diff] [review]
Incorporates David's style comments
I prefer to review a non-w diff because that saves me the trouble of backing
out the patch afterwards ;-)
Attachment #135143 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Comment 20•21 years ago
|
||
Updated•21 years ago
|
Attachment #135143 -
Flags: superreview?(bienvenu) → superreview+
Assignee | ||
Comment 21•21 years ago
|
||
Fixed! Thanks for the original patch, Neil!
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 22•21 years ago
|
||
*** Bug 196123 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•