.count is basically a duplicate of .hasHistoryEntries, it has never reported the actual count. We don't need two attributes providing the same information.

Comment on attachment 620451 [details] [diff] [review] Patch Review of attachment 620451 [details] [diff] [review]: ----------------------------------------------------------------- You should also fix call points, replacing PlacesUtils.bhistory.count with PlacesUtils.history.hasHistoryEntries. This is what I found so far: http://mxr.mozilla.org/mozilla-central/search?string=bhistory.count Unfortunately sessionhistory has also a .count and is almost always called just history, so searching just for history.count generates lots of false positives due to sessionHistory. I also tried to search for most common entries like browserHistory.count, browser_history.count, bh.count, hist.count and I couldn't find any use in add-ons mxr, so looks like there shouldn't be much trouble in the removal. Once these are fixed will be worth to make a tryrun to check for eventual other call points.

Try: https://tbpl.mozilla.org/?tree=Try&rev=7aa2e9385e09

I think we can land it now, as the failures seems unrelated. Do you agree?

Comment on attachment 620776 [details] [diff] [review] Patch v2 Review of attachment 620776 [details] [diff] [review]: ----------------------------------------------------------------- yep, though this needs SR cause of the idl change.

Comment on attachment 620776 [details] [diff] [review] Patch v2 Any idea what the potential add-on impact will be? It looks like we had no in-tree callers (outside of tests), so I imagine it should be minimal?

(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #6) > Comment on attachment 620776 [details] [diff] [review] > Patch v2 > > Any idea what the potential add-on impact will be? It looks like we had no > in-tree callers (outside of tests), so I imagine it should be minimal? I didn't find any caller in addons mxr, though as I said in comment 2 it's hard to search cause sessionhistory is often called history, and there are many history.count (I checked most of those and were all about sessionhistory).

Doc updated: https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIBrowserHistory Listed on Firefox 15 for developers.