Closed
Bug 742490
Opened 13 years ago
Closed 6 years ago
WebGL's linkProgram should warn if compile/linking failed even if infolog is empty
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: ehsan.akhgari, Unassigned)
Details
(Whiteboard: webgl-conformance)
Attachments
(1 file)
|
(deleted),
application/x-bzip2
|
Details |
See the testcase attached (sorry that it's not minimal). Look for _glGetShaderInfoLog, which ends up not being called.
|
||
Comment 1•13 years ago
|
||
Using webgl-conformance tracking bug until we switch to a keyword/whiteboard for this.
Blocks: webgl-conformance
|
|
||
Updated•13 years ago
|
No longer blocks: webgl-conformance
Whiteboard: webgl-conformance
|
|
||
Comment 2•13 years ago
|
||
Ehsan, can you remind me what this bug is about? getShaderiv is not a WebGL function.
|
||
Comment 3•13 years ago
|
||
I'm starting to have doubts about where the bug is. I have to retry this.
|
Reporter | |
Comment 4•13 years ago
|
||
Turns out that this is really a bug in the Emscripten implementation of glGetShaderiv, but what confused us was that compileShader is failing without letting anyone know. Perhaps we should log an error to the console when that happens?
Summary: getShaderiv(GL_INFO_LOG_LENGTH) returns 0 as the log length even when the log length is not zero → WebGL's compileShader function should log an error if the compilation failed
|
|
||
Comment 5•13 years ago
|
||
This bug is now almost a duplicate of 745292.
Note that compileShader is not the right place to do that, as compilation can be completely delayed until linkProgram. So linkProgram it is.
The only reason why this is not a dupe of 745292 is that my patch only generates a warning when infolog is non-empty. If some GL impl gave empty infologs on linkProgram failure, we wouldn't report anything, which would be misleading, hence, is worth fixing.
|
|
||
Updated•13 years ago
|
Summary: WebGL's compileShader function should log an error if the compilation failed → WebGL's linkProgram should warn if compile/linking failed even if infolog is empty
|
||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•