Closed
Bug 74759
Opened 24 years ago
Closed 23 years ago
Improve contents of default userChrome.css
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: css-moz, css1, Whiteboard: [Hixie-PF])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
alecf
:
superreview+
|
Details | Diff | Splinter Review |
The current contents make us look like Irix. Is this a good thing?
Assignee | ||
Comment 1•24 years ago
|
||
Interesting example contents:
menubar { display: none; }
toolbar { display: none; }
location { display: none; }
statusbar { display: none; }
extrachrome { display: none; }
directories { display: none; }
title { display: none; }
status { display: none; }
#taskbar { display: none; }
Comment 2•24 years ago
|
||
the default userChrome.css file should probably set the default namespace to
XUL, too, to avoid weirdness.
Component: Browser-General → Style System
QA Contact: doronr → ian
Whiteboard: [Hixie-PF]
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
Assignee | ||
Comment 3•23 years ago
|
||
pushing out to mozilla0.9.3. No way I can get this done for 0.9.2
Going to take this to the newsgroup for some ideas...
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Easier to explain and less error-prone to have explicit namespaces:
+@namespace html url(...);
+@namespace xul url(...);
^^^
xul|tag { }
html|tag { }
Assignee | ||
Comment 8•23 years ago
|
||
All the tags involved are XUL ones. Should I still attach "xul|" to everything
and not declare xul to be the default namespace? While I can do that, it seems
like it would just make the file more confusing to the average
non-XML-namespace-clueful person.
You are right, no need to add further clutter since there is already a prominent
separation user[Chrome|Content].css and that is more than enough in general.
Only power users may go into the trouble of mixing things up, and if they can
do that, they can as well mess with namespaces...
Assignee | ||
Comment 10•23 years ago
|
||
pushing out....
Comments and reviews still welcome.
Target Milestone: mozilla0.9.3 → mozilla0.9.5
Comment 11•23 years ago
|
||
I'm unsure about the user of 'pt' units in screen stylesheets, wouldn't pixels
be a better idea?
Assignee | ||
Comment 12•23 years ago
|
||
Well... I don't know. I avoid "px" like the plague because I use a single
Mozilla profile that lives in AFS on a bunch of computers with fairly varying
screen resolutions. "pt" tend to give such better results that I never even
thought of specifying a font size in "px".
If you feel that for the average user "px" would be better, I'll change that, of
course. :)
Assignee | ||
Updated•23 years ago
|
Attachment #42460 -
Attachment is obsolete: true
Assignee | ||
Comment 13•23 years ago
|
||
So... anyone care to review that patch or tell me something definite one way or
the other on the px/pt issue? Should I just push this out to Future if no one
is willing to review it?
Comment 14•23 years ago
|
||
Looks good, and that will make one bug less from bugzilla... r=rbs
Comment 15•23 years ago
|
||
Comment on attachment 42461 [details] [diff] [review]
Oops. This is the real patch. Ignore that first one. :)
sr=alecf
Attachment #42461 -
Flags: superreview+
Assignee | ||
Comment 16•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•