Closed
Bug 748890
Opened 13 years ago
Closed 12 years ago
Make getting the load context in nsExternalHelperAppService work in multiprocess mode
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jdm
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•12 years ago
|
||
Josh, now that bug 722845 has landed, what needs to be done here?
|
||
Comment 2•12 years ago
|
||
Instead of QIing for nsIChannel, QI for nsIPrivateBrowsingConsumer which supports IPC channels.
|
|
Assignee | |
Comment 3•12 years ago
|
||
OK, I'll take this when bug 722868 lands. I don't know which one of the 24 git branches that I maintain for bug 722868 was the latest one!
Assignee: nobody → ehsan
Depends on: 722868
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #637633 -
Flags: review?(josh)
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 637633 [details] [diff] [review]
Patch (v1)
I prefer folding it all into a |bool inPrivateBrowsing = pbConsumer && pbConsumer->UsePrivateBrowsing()|, but otherwise good.
Attachment #637633 -
Flags: review?(josh) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•