Closed
Bug 75020
Opened 24 years ago
Closed 8 years ago
Much badness in Mozilla stylesheets
Categories
(Core Graveyard :: Tracking, defect)
Core Graveyard
Tracking
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: jacobs, Unassigned)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
I've written an experimental CSS2 parser (that accepts some CSS3)
that is picky enough that it works very nicely as a CSS validator.
I've picked up quite a few errors in CSS files in the Mozilla source
tree. Most aren't serious, but may result in very funky behavior
or happen or not happen(!). I've run this on a slightly older source
tree (circa 20010129), though I suspect that many of these issues
have been there for years.
Simple typos:
mozilla/extensions/irc/xul/skin/chatzilla.css
Syntax error at `<' at or near line 171:1
mozilla/editor/ui/composer/content/EditorAllTags.css
Syntax error at `:' at or near line 32:16
mozilla/themes/blue/navigator/navigator.css
Syntax error at `:' at or near line 120:71
mozilla/themes/classic/communicator/mac/button.css
Syntax error at `:' at or near line 174:20
mozilla/themes/blue/editor/EdImageMap.css
Syntax error at `0px' at or near line 27:15
mozilla/themes/blue/editor/EditorDialog.css
Syntax error at `4px' at or near line 31:26
mozilla/themes/classic/editor/EdImageMap.css
Syntax error at `0px' at or near line 27:15
mozilla/themes/classic/editor/EditorDialog.css
Syntax error at `4px' at or near line 31:26
mozilla/themes/classic/editor/mac/EdImageMap.css
Syntax error at `0px' at or near line 27:15
mozilla/themes/classic/editor/mac/EditorDialog.css
Syntax error at `4px' at or near line 31:26
mozilla/themes/classic/editor/win/EdImageMap.css
Syntax error at `0px' at or near line 27:15
mozilla/themes/classic/editor/win/EditorDialog.css
Syntax error at `4px' at or near line 31:26
mozilla/themes/modern/editor/EdImageMap.css
Syntax error at `0px' at or near line 27:15
mozilla/themes/modern/editor/EditorDialog.css
Syntax error at `4px' at or near line 31:26
Hidden 0xA0 character in file at 29:1
mozilla/themes/classic/messenger/mac/messenger.css
Syntax error at `display' at or near line 29:5
mozilla/themes/classic/messenger/win/messenger.css
Syntax error at `display' at or near line 29:5
CSS2 now requires that classes starting with a number must have them escaped
(e.g. .\3rd-column-spring). See CSS2 Appendix D:
mozilla/themes/classic/messenger/addressbook/mac/addressbook.css
Syntax error at `.3rd-column-spring' at or near line 366:2
mozilla/themes/classic/messenger/addressbook/win/addressbook.css
Syntax error at `.3rd-column-spring' at or near line 326:2
mozilla/themes/classic/messenger/addressbook/addressbook.css
Syntax error at `.3rd-column-spring' at or near line 356:2
mozilla/themes/modern/messenger/addressbook/addressbook.css
Syntax error at `.3rd-column-spring' at or near line 381:2
Wrong comment characters:
mozilla/extensions/irc/xul/tests/test2.css
Syntax error at `#' at or near line 1:1
Invalid whitespace between identifier and (
mozilla/layout/html/tests/css/clip.css
Syntax error at `(' at or near line 33:19
Martian CSS:
mozilla/layout/html/tests/css/content.css
Syntax error at `[' at or near line 29:25
Can't nest comments:
mozilla/layout/html/tests/table/bugs/bug12012.css
Syntax error at `}' at or near line 119:1
Unterminated comment:
mozilla/themes/blue/communicator/menubutton.css
Syntax error at `/' at or near line 106:4
Invalid C++ style comments:
mozilla/rdf/tests/dsds/DataSourceViewer.css
C++ style comment at or near line 7:1
mozilla/layout/html/tests/css/IMPORTANT.css
C++ style comment at or near line 22:1
mozilla/layout/html/tests/css/INVALID.css
C++ style comment at or near line 22:1
mozilla/layout/html/tests/css/SELECTORS.css
C++ style comment at or near line 22:1
mozilla/themes/classic/messenger/addressbook/mac/addressbook.css
C++ style comment at or near line 328:13
mozilla/themes/classic/messenger/addressbook/win/addressbook.css
C++ style comment at or near line 274:13
mozilla/themes/classic/messenger/addressbook/addressbook.css
C++ style comment at or near line 318:13
mozilla/themes/modern/editor/EditorToolbars.css
C++ style comment at or near line 391:1
mozilla/themes/modern/global/radio.css
C++ style comment at or near line 33:1
mozilla/themes/modern/messenger/addressbook/addressbook.css
C++ style comment at or near line 323:13
mozilla/xpfe/browser/src/navigator-goofy.css
C++ style comment at or near line 64:1
mozilla/xpfe/browser/src/navigator-mozillazine0.css
C++ style comment at or near line 64:1
mozilla/xpfe/browser/src/navigator-shiny.css
C++ style comment at or near line 64:1
evaughan@netscape.com was nice enough to sign these ones...
mozilla/themes/classic/global/mac/global.css
C++ style comment at or near line 125:27
mozilla/themes/classic/global/mac/toolbar.css
C++ style comment at or near line 16:27
mozilla/themes/classic/global/unix/global.css
C++ style comment at or near line 125:27
mozilla/themes/classic/global/unix/toolbar.css
C++ style comment at or near line 20:27
mozilla/themes/classic/global/win/global.css
C++ style comment at or near line 121:27
mozilla/themes/classic/global/win/toolbar.css
C++ style comment at or near line 13:27
mozilla/themes/modern/global/global.css
C++ style comment at or near line 126:27
mozilla/themes/modern/global/toolbar.css
C++ style comment at or near line 10:1
Comment 1•24 years ago
|
||
Thanks!
Ok. We're going to go through these one component at a time. First off:
Chatzilla!
Robert: give me a shout when you're done fixing all errors in your CSS (or when
you get fed up with this bug). Thanks!
Assignee: pierre → rginda
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Component: Style System → chatzilla
Ever confirmed: true
QA Contact: ian → mozilla
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
Maybe I'll pitch in if I learn how to use CVS...
jake
Comment 4•23 years ago
|
||
ccing hewitt since a bunch of these are in themes... the "Chatzilla first"
approach seems to have failed.
Comment 5•23 years ago
|
||
I've already attached a patch for chatzilla, was I supposed to "pass it on" somehow?
And the file being patched is not even normally used. (test2.css)
So, please do reassign this to the next person who needs to work on it.
Reporter | ||
Comment 6•23 years ago
|
||
As further motivation, I'll be running my new and improved
semi-validating CSS3* parser on the Mozilla source tree
in the next few weeks. It is much smarter and picks up many
things that the previous one did not. It can also extract
embedded stylesheets from HTML/XML/SGML, so it will have
more opportunities for find problems.
Before this happens, it would be nice if the ones I reported
previously were addressed, if at all possible. These problems
aren't rocket science -- they're almost always trivial fixes
and those that aren't are likely to cause subtle problems.
* My new parser handles all of CSS2, plus CSS3 selectors and
namespaces. To see it in action as part of a
CSS->English source-to-source translator take a look at:
http://gallery.theopalgroup.com/selectoracle/index.html
Comment 7•23 years ago
|
||
Kevin, I would suggest the following. Run the parser. File separate bugs on
all the components that have problems in them and make this a tracking bug that
depends on all the new ones... That should make it a lot easier to get problems
resolved one component at a time. Can you do that?
Reporter | ||
Comment 8•23 years ago
|
||
Sure, if that will make things easier. I will be out of town for the next
week, so this won't happen until I get back and catch up.
Comment 9•23 years ago
|
||
Moving this out of chatzilla. Anyone want to take it?
Component: chatzilla → Browser-General
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•16 years ago
|
Assignee: rginda → general
QA Contact: samuel → general
Updated•16 years ago
|
Assignee: general → nobody
Component: General → DOM: CSS Object Model
Product: SeaMonkey → Core
QA Contact: general → general
Updated•14 years ago
|
QA Contact: general → style-system
Updated•14 years ago
|
Component: DOM: CSS Object Model → Tracking
QA Contact: style-system → chofmann
Comment 11•8 years ago
|
||
Marking all tracking bugs which haven't been updated since 2014 as INCOMPLETE.
If this bug is still relevant, please reopen it and move it into a bugzilla component related to the work
being tracked. The Core: Tracking component will no longer be used.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•