Closed
Bug 75142
Opened 24 years ago
Closed 23 years ago
when opening a bookmarks menu that needs scroll arrows, ALL parent menus get scroll arrows
Categories
(Core :: XUL, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: b_ironfist, Assigned: mikepinkerton)
References
Details
(Whiteboard: [br])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
image/jpeg
|
Details |
moz build: 2001040604
when I browse bookmarks to a folder that requires scroll buttons to view it comepletely, all my bookmark folders get scroll buttons
they continue to have scroll buttons (whether they need them or not) throughout the mozilla session
upon restarting mozilla the extranious scroll buttons are gone (until I browse to a folder in my bookmarks that needs scroll buttons that is)
scroll buttons apprear 100% of the time I fold out a large bookmark folder
the buttons should be appearing on ONLY the folders that need them, not everything
Reporter | ||
Comment 1•24 years ago
|
||
steps to (re)produce bug
1: click on "bookmarks"
2. browse to a folder listing that is too large for screen display
3. sit back and watch as mozilla adds scroll buttons to all your bookmark folders
Reporter | ||
Comment 2•24 years ago
|
||
upon further investigation, I noticed that it is not ALL bookmark folders that get the scroll buttons, just the one that is supposed to get it, and all it's parents
- ie. all OPEN bookmark folders get scrollbuttons (which don't go away until restarting mozilla)
Also seeing this Windows 2000, build 2001040420. This doesn't happen on build
2001040120
Comment 4•24 years ago
|
||
a temporary workaround for this problem.
patch against mozilla/content/xul/content/src/nsXULElement.cpp.
--- nsXULElement.cpp.org Tue Apr 10 09:05:49 2001
+++ nsXULElement.cpp Tue Apr 10 09:09:20 2001
@@ -3682,6 +3682,7 @@
//Bubbling stage
if (NS_EVENT_FLAG_CAPTURE != aFlags) {
+ if(parent.get() != mParent) parent = mParent;
if (parent != nsnull) {
// We have a parent. Let them field the event.
ret = parent->HandleDOMEvent(aPresContext, aEvent, aDOMEvent,
Comment 5•24 years ago
|
||
Marking NEW to get someone to take a look at the patch.
Comment 7•24 years ago
|
||
changing component and tweaking summary
Summary: when openening a bookmarks folder that needs scroll buttons, ALL folders get scroll buttons → when opening a bookmarks menu that needs scroll arrows, ALL parent menus get scroll arrows
Comment 8•24 years ago
|
||
for real this time
Assignee: ben → pinkerton
Component: Bookmarks → XP Toolkit/Widgets: Menus
QA Contact: claudius → jrgm
Comment 10•24 years ago
|
||
This also affects Linux builds (including build 2001060508)
Comment 11•23 years ago
|
||
*** Bug 76063 has been marked as a duplicate of this bug. ***
Comment 12•23 years ago
|
||
Screenshots I had put into bug 76063...
attachment 34915 [details] - bookmarks menu
attachment 34916 [details] - Imported IE Favorites submenu
attachment 34917 [details] - Auto-scrolling submenu is created, and all three menus are
now auto-scroll.
Comment 13•23 years ago
|
||
This patch doesn't sit well with me. "if(parent.get() != mParent) parent =
mParent" is a long way of saying "parent = mParent", which doesn't seem right.
Comment 14•23 years ago
|
||
Comment 15•23 years ago
|
||
*** Bug 86965 has been marked as a duplicate of this bug. ***
Comment 16•23 years ago
|
||
*** Bug 91525 has been marked as a duplicate of this bug. ***
Comment 17•23 years ago
|
||
Isn't this the same as bug 84121?
Comment 18•23 years ago
|
||
No it's not. Compare the screenshots that I listed in this bug on 2001-06-11
10:03 to a screenshot from 84121
(http://bugzilla.mozilla.org/showattachment.cgi?attach_id=37665)
It may end up that the two bugs are related, but they need to be kept separate.
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Comment 19•23 years ago
|
||
Who originally did the scrolling menu work, evaughan?
Assignee | ||
Comment 20•23 years ago
|
||
yes, and he's, well, not doing much these days.
Status: NEW → ASSIGNED
Comment 21•23 years ago
|
||
cc:ing Jan, who's done some work with scrolling menus before.
Comment 22•23 years ago
|
||
*** Bug 93633 has been marked as a duplicate of this bug. ***
Comment 23•23 years ago
|
||
Comment 24•23 years ago
|
||
I took look and got a patch.
Patch is not well tested but it fixes described problem.
Comment 25•23 years ago
|
||
this kinda makes sense to me. kinda. pink, wanna have a looksee in evaughan's
absence?
Whiteboard: [br]
Comment 26•23 years ago
|
||
I'm running with the patch right now. It resolves the problem and everything
else, such as menulists, _appears_ to be working properly.
Comment 27•23 years ago
|
||
yeah, i like this. sr=hyatt
r=pink also
Comment 28•23 years ago
|
||
thanks, I'll check it in when tree opens
Comment 29•23 years ago
|
||
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 30•23 years ago
|
||
*** Bug 94283 has been marked as a duplicate of this bug. ***
Comment 32•23 years ago
|
||
As of build 2001080804 - WinMe
This does indeed fix the multi-arrow problem thanks. However, as it fixes some
of the problem with the menu scroll bars being below the screen it does not fix
every instance. (Not sure if this was intended to do this as well, or just a
nice side effect) I will attach a screen shot.
Comment 33•23 years ago
|
||
Comment 34•23 years ago
|
||
Christoph: that's bug 84121
Comment 35•23 years ago
|
||
*** Bug 94591 has been marked as a duplicate of this bug. ***
Comment 36•23 years ago
|
||
*** Bug 95177 has been marked as a duplicate of this bug. ***
Comment 37•23 years ago
|
||
*** Bug 95950 has been marked as a duplicate of this bug. ***
Comment 38•23 years ago
|
||
*** Bug 97635 has been marked as a duplicate of this bug. ***
Comment 39•22 years ago
|
||
The "persistent" scroll arrows appear also in another context. When opening
bookmarks menu, which has it's height equal to the maximized Mozilla window,
with Mozilla window not at the top of the workspace (i.e. not minimized) this
menu gets scroll arrows. Thats good. But when one maximize Mozilla window they
do not vanish. The bookmarks menu *with scroll arrows* has its height larger
than screen height. The scroll arrows necessary only because there are scroll
arrows. They have to scroll only one row of bookmarks.
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•