Closed
Bug 752067
Opened 13 years ago
Closed 13 years ago
build broken in ipc after prctl changes
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: mpk, Assigned: mpk)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
Landing the patch for bug 750498 broke builds in FreeBSD (and probably OpenBSD too).
I'll attach a patch shortly.
Assignee | ||
Comment 1•13 years ago
|
||
This patch unbreaks the bustage due to "prctl.h not found" on FreeBSD.
Landry, before asking for review I'd like to know if the builds are
indeed broken on OpenBSD too and if this patch remedies the problem.
Comment 2•13 years ago
|
||
http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/376/steps/build/logs/stdio
So yes, broken for me too. Testing you fix.
Comment 3•13 years ago
|
||
Works here. As a sidenote, maybe we can add the NetBSD/DragonflyBSD folks to the ifdefs, even if they don't seem to be here to fight for their cause ?
Assignee | ||
Comment 4•13 years ago
|
||
Sure, makes sense. DragonFly's implementation looks a lot like ours,
but NetBSD's is a bit different, so I hope I got it right.
There has been little NetBSD-related activity in Bugzilla for the last
two years. Landry, do you know any of NetBSD's Firefox maintainers?
If not I'll try to cc: tnn.
Attachment #621193 -
Attachment is obsolete: true
Comment 5•13 years ago
|
||
tnn@ did a lot in the past, but it seems those days ryoon@ and martin@ take care of that.
Comment 6•13 years ago
|
||
Re: activity: nobody ever commits our patches, so we just keep accumulating more and more ;-) There is no pthread_np.h on NetBSD, the pthread_setname_np() looks correct.
Comment 7•13 years ago
|
||
I think as of now the patch will include <sys/prctl.h> on NetBSD and that's probably not intended.
Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 621276 [details] [diff] [review]
patch v2 (supporting Free/Net/Open/DragonFly - BSD)
You're right. :-)
Now let's concentrate on that "BSD super bug" and its patch over at bug 753046.
Attachment #621276 -
Attachment is obsolete: true
Comment 9•13 years ago
|
||
We can still land that first.. oh well :)
Assignee | ||
Comment 10•13 years ago
|
||
We still can, but I'll need to fix it anyway. :-)
Comment 11•13 years ago
|
||
Since #753046 is not moving, can we land a quickfix now for that bug ? that'd be one less patch in my mqs..
Assignee | ||
Comment 12•13 years ago
|
||
Yes. The "BSD super bug" will require quite a bit of work.
This patch should work for the 4 BSDs without breaking other platforms.
Attachment #625254 -
Flags: review?(jones.chris.g)
Comment on attachment 625254 [details] [diff] [review]
patch v3 (supporting Free/Net/Open/DragonFly - BSD)
rs=me
Attachment #625254 -
Flags: review?(jones.chris.g) → review+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 14•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbf995d86990
Thanks for the patch!
Comment 15•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•