Open Bug 752188 Opened 13 years ago Updated 2 years ago

"Edit Contact" popup (for message header recipient): Ctrl+C keyboard shortcut not working to copy selected text of email address in "Email" field

Categories

(Thunderbird :: Message Reader UI, defect)

Product:
Thunderbird
Component:
Message Reader UI
Type:
defect

Tracking

(Not tracked)

Status:
ASSIGNED

People

(Reporter: martin, Assigned: lilian.braud)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Keywords: good-first-bug, Whiteboard: [STR comment 2])

Attachments

(2 files)

Screenshot 1: Pressing Ctrl+C on selected text of Email field has no effect, but works for Name field
(deleted), image/png
Details
Bug 752188 - Allow Ctrl/cmd+C/A in read-only fields in Edit Contact Panel. r=thomasD
(deleted), text/x-phabricator-request
Details
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:12.0) Gecko/20100101 Firefox/12.0 Build ID: 20120420145725 Steps to reproduce: View email. Above "An"-Field (German language) press mouse. Select "Kontakt bearbeiten..." In Field "E-Mail-Adress" press Ctrl-C to cut some text. Selected text _not_ copied to clipboard. By pressing right mouse key an selecting "Kopieren" the text is copied to clipboard. Actual results: Selected text _not_ copied to clipboard. Expected results: Selected text should be copied to clipboard.
(In reply to martin from comment #0) You cannot copy the sender email using keyboard while you are viewing a message, you can do it by mouse only.
STR 1 in message reader, click on recipient, then "Edit contact..." 2 In "Edit contact" popup, select/highlight email address in Email field 3 press Ctrl+C Actual Result - selected email address text is not copied to clipboard Expected Result - selected email address text should be copied to clipboard - by analogy, Ctrl+X -> Cut Yeah, those trivial, yet basic operations should work anywhere no matter what... -> Confirming (In reply to martin from comment #0) Partial workaround: There is an easier way if you only want to copy the full email address of a recipient from message header (without Edit Contact): - click on recipient, then "Copy email address" @Martin (reporter), pls don't use German in bmo, because people won't understand your bug report and you'll get responses that are not related to your issue (like comment 1). (Die paar Begriffe kriegst du auch noch auf Englisch hin... ;)
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Version: 12 → Trunk
Summary: cut not working by keyboard (by mouse it works) → "Edit Contact" popup (for message header recipient): Ctrl+C and Ctrl+X keyboard shortcuts not working for selected text of email address in "Email" field
Component: Address Book → Message Reader UI
QA Contact: address-book → message-reader
Whiteboard: [STR comment 2]
Blocks: 545559
(In reply to Hashem Masoud from comment #1) > (In reply to martin from comment #0) > You cannot copy the sender email using keyboard while you are viewing a > message, you can do it by mouse only. That's a different issue, Bug 167010.
It's obvious that Ctrl+C must always copy selected text no matter where, so for all practical purposes, this has ui-review+
Whiteboard: [STR comment 2] → [good first bug][STR comment 2][has ui-review+]
That's not how this project works, and I'm afraid you're not yet on the list of approved ui-reviewers, so I'm clearing the ui-r+.
Whiteboard: [good first bug][STR comment 2][has ui-review+] → [good first bug][STR comment 2]
Summary: "Edit Contact" popup (for message header recipient): Ctrl+C and Ctrl+X keyboard shortcuts not working for selected text of email address in "Email" field → "Edit Contact" popup (for message header recipient): Ctrl+C keyboard shortcut not working to copy selected text of email address in "Email" field
Keywords: good-first-bug
Whiteboard: [good first bug][STR comment 2] → [STR comment 2]

Just to clarify, per my STR in comment 2:

Ctrl+C on selected text in Email field of Edit Contact dialog fails, whereas it works for Name field.
In terms of UX, there's no logical reason why Ctrl+C should fail on selectable plaintext (instead, that's violating basic UX standards).

I've looked at the code and this might be a simple fix. We have an explicit keypress-handler which for the read-only case does nothing to allow Ctrl+C/X to sail through. As a caveat, there's a comment that we need to prevent keypresses of this dialog to end up on the main window (like A for Archive). It all looks very hacky.

Depends on: 1688483
Assignee: nobody → lilian.braud
Status: NEW → ASSIGNED
Attachment #9213192 - Attachment description: Bug 752188 - Allow Ctrl/cmd+C/X/A in read-only fields in Edit Contact Panel. r=thomasD → Bug 752188 - Allow Ctrl/cmd+C/A in read-only fields in Edit Contact Panel. r=thomasD
Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: