Closed Bug 75432 Opened 24 years ago Closed 24 years ago

nsImageBoxFrame does lots of redundant GetShells

Categories

(Core :: Graphics: ImageLib, defect)

All
Mac System 8.5
defect
Not set
trivial

Tracking

()

VERIFIED FIXED
mozilla0.9

People

(Reporter: sfraser_bugs, Assigned: pavlov)

Details

(Whiteboard: [imagelib])

Attachments

(1 file)

nsImageBoxFrame does this in a bunch of places: nsCOMPtr<nsIPresShell> presShell; aPresContext->GetShell(getter_AddRefs(presShell)); for no reason; the presShell is unused. This happens in nsImageBoxFrame::OnStartContainer and nsImageBoxFrame::OnDataAvailable
Whiteboard: [imagelib]
i removed these
Severity: normal → trivial
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Attached patch remove the extra stuff (deleted) — Splinter Review
simon, please sr= saari, please r=
Keywords: patch
sr=hyatt
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verfied fix checked into lxr.mozilla.org
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: