Closed Bug 75487 Opened 24 years ago Closed 24 years ago

make Find on Page dialog wider

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: sfraser_bugs)

Details

Attachments

(2 files)

the Find on Page dialog is a bit too narrow. smfr says he'll have a patch for this soon.
On it.
Status: NEW → ASSIGNED
Attached patch Patch to finddialog.xul (deleted) — Splinter Review
This patch: 1. Changes the dialog to use a <grid>, for better (but not perfect) alignment of the label and textbox. 2. Makes the dialog wider, and the textfield size with the dialog width. See also bug 9131, which has a fix to make persistence work again.
A couple of comments: prefer <spring/> as a space taker in grid rows to <box/>, and prefer <hbox/> and <vbox/> to <box/> with the orient/align attribute set. otherwise, r=ben@netscape.com
alecf, can you sr=? Thanks.
Simon has requested my review be sr. Without further ado... sr=ben@netscape.com
I'm not overly fond of the hardcoded window style, but since I'll be addressing all inline style soon en masse, r=blake
Done.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verified
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: