Closed
Bug 75556
Opened 24 years ago
Closed 24 years ago
doesn't load this page
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: tracy, Assigned: ccarlen)
References
()
Details
(Keywords: smoketest)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
seen on windows mfcembed 2001-04-11
-use the mfcembed product
-attempt smoketest EM.15 by clicking on the link for the HTTPAuth (given above)
expected results: password dialogue opens
tested results: status very briefly says connecting to aol.com then nothing
happens: the password dialogue doesn't open as expected.
Comment 3•24 years ago
|
||
I just tested it and it seems to work ok.
http://browsertest.we.aol.com/tests/private
^------------ a missing 'b' in the url?
Reporter | ||
Comment 4•24 years ago
|
||
that was a typo on my part...
loading the correct page with the mfcembed product doesn't work on my machine
mfcEmbed opens a username/password prompt at the given URL in a build I pulled
and made this morning.
Assignee | ||
Comment 6•24 years ago
|
||
It works when run from the mozilla dir. Checking for a packaging problem...
Assignee | ||
Comment 7•24 years ago
|
||
A bug on my part when wallet (single-signon) is not available. Patch coming up.
I thought wallet was installed in the embed config ?? Should be or password
persistence won't work.
Assignee | ||
Comment 8•24 years ago
|
||
Assignee | ||
Comment 9•24 years ago
|
||
Comment 10•24 years ago
|
||
I'm pretty sure wallet is not supposed to be part of the embedding release. Not
for this version yet, anyway. I think we should just gracefully return a normal,
non-persistent prompt object if the service isn't available, rather than failing
with an error. For that matter, why not just use
nsIWindowWatcher::GetNewAuthPrompt, which I thought was supposed to be the single
one true central way to get those things. Does this version need to do something
slightly different? If so, why? (Just curious; I don't mean to sound uppity.)
Assignee | ||
Comment 11•24 years ago
|
||
You're right. We do need to gracefully return a non-persistent auth prompt when
the component isn't available. That's what was supposed to happen if not for the
logic error I made.
The reason why I'm not using nsIWindowWatcher::GetNewAuthPrompt is that the
nsIPrompt impls in some embedding samples need to be moved out of their chrome
and into an override component. When that is done, everything will use
windowwatcher.
Comment 12•24 years ago
|
||
This is holding the tree closed. Who is reviewing?
Comment 13•24 years ago
|
||
The patches do work. This confuses me, but I guess that's my fault. r=me on the
first one (attachment 30450 [details] [diff] [review]), which fixes the bug. I still think we can't put
wallet in the embedding distribution, so I say we hold off on the second patch
(which isn't necessary to close this bug) until we can get confirmation.
Comment 14•24 years ago
|
||
Oh. Right. Now I'm not confused. The first patch is good. Go for it.
Assignee | ||
Comment 15•24 years ago
|
||
Chris, can you give sr on 1st patch only?
Comment 16•24 years ago
|
||
sr=sfraser on the first patch
Assignee | ||
Comment 17•24 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 18•24 years ago
|
||
Looking at EM.15 on the smoketests, wallet would need to be there, else it would
fail the test. This part:
* (2) Switch back to the original profile and visit the site again. The name
and password dialog should appear and be pre-filled.
isn't going to work without wallet. Tracy, unless wallet recently got removed
from the Embed dist, how has this ever worked?
Comment 19•24 years ago
|
||
There's a confusion here in terminology between wallet (a.k.a. form manager) and
single signon (a.k.a. password manager). Wallet is not required for embedding
but password manager is.
Assignee | ||
Comment 20•24 years ago
|
||
Let me put it another way: wallet.dll (on Windows) is needed in order for
single-signon to be available.
Comment 21•24 years ago
|
||
Yup. After a mini-wallet education, r=me on the second patch, too. Good stuff for
a resolved bug.
Reporter | ||
Comment 22•24 years ago
|
||
Conrad...it hasn't worked
Bug 70715 was filed against the password dialogue missing the remember me
checkbox.
by the way, the password is remembered somehow, at least temporarily. For it is
possible to return to that site later in a session without the password dialogue
coming up. Or is that somehow a cache thing allowing that?
Assignee | ||
Comment 23•24 years ago
|
||
I'll look at bug 70715.
HTTP remembers the password for the session - password manager remembers it
between sessions.
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•