Closed
Bug 75924
Opened 24 years ago
Closed 16 years ago
make --with-extensions=all do what it says
Categories
(Firefox Build System :: General, defect, P5)
Tracking
(Not tracked)
RESOLVED
WONTFIX
Future
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(6 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
I'd like to make --with-extensions=all more accurate, so that people
who are trying not to break extensions will actually build all working
extensions when the try to do so. This would mean that the tinderboxes
(on Ports) that build --with-extensions=all would be building these
extensions. As a first pass, I'd like to add the extensions that
clearly seem ready to be built -- those that are in allmakefiles.sh --
part of --with-extensions=all. That means adding inspector,
access-builtin, and transformiix to --with-extensions=all.
hewitt, aaronl, and peterv: Is this OK with you?
I'll attach a patch once I add the REQUIRES lines...
Assignee | ||
Comment 1•24 years ago
|
||
It would be nice to fix the transformiix build system to use archives rather
than do everything (again) in extensions/transformiix/build/Makefile.in first
though...
Assignee | ||
Comment 2•24 years ago
|
||
Comment 3•24 years ago
|
||
Adding Axel Hecht, he knows much more about the Transformiix unix build system
than I do. David, could you expand a little on your last comment, I don't
understand what you mean. Also note that Transformiix is very close to being
turned on in the default build.
Comment 4•24 years ago
|
||
Adding inspector is fine with me. It should build on win32, mac, and linux...
who knows what will happen on other platforms.
Comment 5•24 years ago
|
||
transformiix is blocked by the old makefiles. See 74879.
Concerning David (recap of irc discussion): I don't like the idea
of static libs more or less than listing the object files twice.
"Due to historical reasons" bla applies.
We have a few dirs with just one .cpp, and my fingers curl up to my knees on the
idea of static libs for those. IMHO, it's not worth the effort converting.
Axel
r=cls on attach 30774. I assume that changes for vixen, p3p, etc are in the works?
Comment 7•24 years ago
|
||
I'd would like the REQUIRES lines in transformiix to be ifdef MOZ_XSL.
Currently, only the mozmodule depends on other stuff in mozilla, and we might
at one time have a dependency on string only for standalone.
Axel
Assignee | ||
Comment 8•24 years ago
|
||
aaronl said (on IRC) that this is fine with him. So I just need to #ifdef those
REQUIRES lines...
Assignee | ||
Comment 9•24 years ago
|
||
Comment 10•24 years ago
|
||
r=cls
Comment 11•24 years ago
|
||
extensions=all would build transformiix standalone this way, but to build the
moz module, you need to set MOZ_XSL.
This should be synched/merged with 72141.
Axel
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 12•24 years ago
|
||
Comment 13•24 years ago
|
||
sr=hewitt
Comment 14•24 years ago
|
||
David, if you've verified that it builds the transformiix module (not the
standalone), r=peterv. I'm surprised that that works.
Assignee | ||
Comment 15•24 years ago
|
||
No, it (without --enable-xsl) builds the standalone. But I'd rather have this
in first and then fix bug 72141 (which would involve making it so that it really
builds the transformiix module).
Assignee | ||
Comment 16•24 years ago
|
||
I just checked in the bustage fixes (including the ifdef-ed REQUIRES lines for
transformiix) and I added access-builtin and inspector to --with-extensions=all,
but I didn't add transformiix yet, since it would currently build the standalone
(cls agreed that it should wait). It should be added as part of bug 72141.
Assignee | ||
Comment 17•24 years ago
|
||
Comment 18•24 years ago
|
||
r=cls on the latest attach
Comment 19•24 years ago
|
||
LIB_SUFFIX is preferred over hardcoding .a
Assignee | ||
Comment 20•24 years ago
|
||
Fixed the error mkaply pointed out. (For the record, the patch above fixed the
fact that we were creating "libinspector_s" and ".a" where we should have been
creating "libinspector_s.a", and the cause of the problem was a space at the end
of the LIBRARY_NAME line.)
I also had to make inspector link against gkgfx and libgkconshared_s to fix AIX
bustage. The latter dependency really has to go. The errors that led me to do
that were:
ld: 0711-317 ERROR: Undefined symbol: .NS_HexToRGB
ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::AddRefTable()
ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::ReleaseTable()
ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::GetStringValue(nsCSSProperty)
ld: 0711-317 ERROR: Undefined symbol: .nsCSSProps::LookupProperty(const nsAString&)
(I wonder why it was linking against rdfutil_s to begin with... that would be
good to remove as well.)
I also fixed some true->PR_TRUE and false->PR_FALSE bustage in inspector and one
file in access-builtin that had Windows line endings.
Assignee | ||
Comment 21•24 years ago
|
||
I filed bug 79091 about inspector's link-time dependencies.
Assignee | ||
Comment 22•23 years ago
|
||
Finishing this isn't at the top of my radar right now. If someone else wants
to, go ahead. The first bit was a good bit more work than I intended...
Priority: -- → P4
Target Milestone: --- → Future
Assignee | ||
Comment 23•23 years ago
|
||
I'll have a patch for the next step shortly. This patch adds:
ctl cview p3p universalchardet vixen
pics seems to require numerous files that aren't in the tree.
python seems complicated.
This patch adds new Makefile.in files for universalchardet and makes extensive
changes to p3p to get it building again (since it clearly hasn't been built for
quite a while).
Target Milestone: Future → mozilla0.9.4
Assignee | ||
Comment 24•23 years ago
|
||
Assignee | ||
Comment 25•23 years ago
|
||
Assignee | ||
Comment 26•23 years ago
|
||
Assignee | ||
Comment 27•23 years ago
|
||
Comment 28•23 years ago
|
||
r=cls on the makefile changes
Assignee | ||
Comment 29•23 years ago
|
||
harishd said by email that the p3p changes were fine with him
yokoyama said adding the universalchardet makefiles was fine (and noted bug
92341, which says it should be on by default)
I still haven't heard back from katakai (for ctl), rginda (for cview), or ben
(for vixen).
Assignee | ||
Comment 30•23 years ago
|
||
I'm actually thinking I probably shouldn't add p3p since it adds significant
leaks to startup and that will make the leak stats more confusing.
Comment 31•23 years ago
|
||
There's a separate bug for ctl, bug 95258.
Comment 32•23 years ago
|
||
sr=tor
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Comment 33•23 years ago
|
||
*** Bug 91305 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.6 → Future
Assignee | ||
Updated•23 years ago
|
Priority: P4 → P5
Comment 34•21 years ago
|
||
*** Bug 221233 has been marked as a duplicate of this bug. ***
Comment 35•21 years ago
|
||
I'm not sure that Bug 221233 is actually a duplicate of this one, since cview is
actually included in --with-extensions=all in configure, but it just doesn't get
compiled. (Or is that what this bug is about?)
Updated•20 years ago
|
Product: Browser → Seamonkey
Comment 36•16 years ago
|
||
David,
Are you still working on this ?
Comment 38•16 years ago
|
||
And as bug 450015 notes, neither was anyone else. At all. Ever.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•