Closed Bug 75982 Opened 24 years ago Closed 23 years ago

[BiDi] Turn on the IBMBIDI #ifdef

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

(Keywords: intl, Whiteboard: ask leaf to review 2001-05-07 19:00)

Attachments

(4 files)

This bug is to actually enable IBMBIDI in the build. I will make all bugs that are fixed by the IBMBIDI code dependent on this bug.
Blocks: 3687
Blocks: 73872
Blocks: 64490
Blocks: 26371
Blocks: 24199
Blocks: 17175
Status: NEW → ASSIGNED
Blocks: 35028
Blocks: 74063
Blocks: 62134
Blocks: 51916
Chris, would you please take a look at the Linux and Windows patches in this bug report, and let me know if they look OK? Autoconf will be run automatically to create a new configure, right? (Once I check in.) By the way, we're not ready to turn on IBMBIDI by default. I just want to make sure we have the right patches in here, that's all.
The patches look right to me.
Summary: Turn on the IBMBIDI #ifdef → [BiDi] Turn on the IBMBIDI #ifdef
cls, please review the most recent makefile.win patch. I found that I had to make these changes in order to turn on the IBMBIDI ifdef by default. In most cases, I'm just adding an include for config.mak (hopefully in the right place). But in one case, I'm also changing INCS to LINCS. Are you a Windows makefile expert? If not, do you know who should review these? Thanks.
Depends on: 76931, 76933, 76939, 77190
leaf would be the preferred person to review win32 makefile changes.
Hi Leaf, would you please review the 4th patch (makefile.win changes)? Thanks!
No longer depends on: 76931
No longer depends on: 77190
Depends on: 7693, 74587
No longer depends on: 76939
No longer depends on: 74587
Depends on: 74587, 76939
No longer depends on: 7693
No longer depends on: 74587
ask leaf to review
Whiteboard: ask leaf to review 2001-05-07 19:00
I'm shocked that these makefile.win files didn't have config.mak included in the first place, so r=leaf for http://bugzilla.mozilla.org/showattachment.cgi?attach_id=32213
done. mark this bug fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Changing component to BiDi and adding keyword intl.
Component: Internationalization → BiDi Hebrew & Arabic
Keywords: intl
Changing QA contact to default Bidi-Hebrew owner giladehven@hotmail.com.
QA Contact: andreasb → giladehven
Verified fixed
Status: RESOLVED → VERIFIED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: giladehven → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: