Closed Bug 76385 Opened 24 years ago Closed 24 years ago

Displaying an news message more than once in one session doesn't mark the message read

Categories

(MailNews Core :: Networking: NNTP, defect, P2)

x86
Other
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: sspitzer, Assigned: Bienvenu)

References

Details

(Whiteboard: [nsbeta1+])

Attachments

(2 files)

Displaying an news message more than once in one session doesn't mark the message read just like #24787.
I'll take this - this just requires that we set m_key correctly on the protocol object when reading from the cache - the rest of the code should just work. This is set usually in nsNNTPProtocol::ParseURL
Assignee: sspitzer → bienvenu
QA Contact: esther → stephend
Attached patch part 1 of fix, fix for newsdb (deleted) — Splinter Review
OK, the second part of the fix makes the code that reads from the mem cache parse the url so that m_key will get set, and we'll mark the msg read. The db part is more subtle - the news db code that marks messages read or unread was not updating nsMsgHdr::m_flags, only the read set. This caused some problems trying to toggle the read state, which is fixed by making sure the news code keeps m_flags in sync. Ready for review, but you might want to try this out, Seth, to make sure I didn't break anything in news.
I reviewed and tested the fix. it looks good. r/sr=sspitzer
r=naving
Keywords: nsbeta1
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
*** Bug 72838 has been marked as a duplicate of this bug. ***
Verified fixed on: Windows 2000 Build 2001043004 Mac OS 9.1 Build 2001043008 RedHat 7.0 with Ximian (Gnome) Build 2001043008.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: