Closed
Bug 76385
Opened 24 years ago
Closed 24 years ago
Displaying an news message more than once in one session doesn't mark the message read
Categories
(MailNews Core :: Networking: NNTP, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: sspitzer, Assigned: Bienvenu)
References
Details
(Whiteboard: [nsbeta1+])
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Displaying an news message more than once in one session doesn't mark the
message read
just like #24787.
Assignee | ||
Comment 1•24 years ago
|
||
I'll take this - this just requires that we set m_key correctly on the protocol
object when reading from the cache - the rest of the code should just work. This
is set usually in nsNNTPProtocol::ParseURL
Assignee: sspitzer → bienvenu
QA Contact: esther → stephend
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
OK, the second part of the fix makes the code that reads from the mem cache
parse the url so that m_key will get set, and we'll mark the msg read. The db
part is more subtle - the news db code that marks messages read or unread was
not updating nsMsgHdr::m_flags, only the read set. This caused some problems
trying to toggle the read state, which is fixed by making sure the news code
keeps m_flags in sync. Ready for review, but you might want to try this out,
Seth, to make sure I didn't break anything in news.
Reporter | ||
Comment 5•24 years ago
|
||
I reviewed and tested the fix. it looks good.
r/sr=sspitzer
Comment 6•24 years ago
|
||
r=naving
Updated•24 years ago
|
Assignee | ||
Comment 7•24 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified fixed on:
Windows 2000 Build 2001043004
Mac OS 9.1 Build 2001043008
RedHat 7.0 with Ximian (Gnome) Build 2001043008.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•