Closed
Bug 771870
Opened 12 years ago
Closed 12 years ago
adding files to js/src seems to require a clobber on tinderbox, sometimes
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: luke, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Here is one example:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b0e6294a7c
with log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13324602&tree=Mozilla-Inbound&full=1
Here is another:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8417741974ba
Both involve adding files to js/src/Makefile.in that are not INSTALLED_HEADERS.
Another clue is that philor pointed out that these are the only csets to add files after bug 748001.
Comment 1•12 years ago
|
||
Comparing a good log to a failed log, one thing that seems to have gone wrong is that a good log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13317288&tree=Mozilla-Inbound
contains the export line:
/builds/slave/m-in-lnx/build/obj-firefox/js/src/config/nsinstall -R -m 644 /builds/slave/m-in-lnx/build/js/src/../public/HashTable.h /builds/slave/m-in-lnx/build/js/src/../public/LegacyIntTypes.h /builds/slave/m-in-lnx/build/js/src/../public/MemoryMetrics.h /builds/slave/m-in-lnx/build/js/src/../public/TemplateLib.h /builds/slave/m-in-lnx/build/js/src/../public/Utility.h /builds/slave/m-in-lnx/build/js/src/../public/Vector.h ./../../dist/include/js
while a bad log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13324597&tree=Mozilla-Inbound
contains the export line:
/builds/slave/m-in-lnx/build/obj-firefox/js/src/config/nsinstall -R -m 644 /builds/slave/m-in-lnx/build/js/src/../public/HashTable.h /builds/slave/m-in-lnx/build/js/src/../public/LegacyIntTypes.h /builds/slave/m-in-lnx/build/js/src/../public/MemoryMetrics.h /builds/slave/m-in-lnx/build/js/src/../public/TemplateLib.h /builds/slave/m-in-lnx/build/js/src/../public/Utility.h /builds/slave/m-in-lnx/build/js/src/../public/Vector.h ./dist/include/js
Notice that the later export line is installing to "./dist/include/js" instead of "./../../dist/include/js". That seems broken.
Assignee | ||
Comment 3•12 years ago
|
||
So, the problem is actually very old, but before bug 763987 it wasn't really important: objdir/js/src/Makefile is created from the top directory with:
/usr/bin/perl $srcdir/build/autoconf/make-makefile -t $topsrcdir -d . js/src/Makefile
topsrcdir is thus wrong in js/src/Makefile.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #3)
> topsrcdir is thus wrong in js/src/Makefile.
and DEPTH, too.
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4)
> (In reply to Mike Hommey [:glandium] from comment #3)
> > topsrcdir is thus wrong in js/src/Makefile.
>
> and DEPTH, too.
huh, no, DEPTH is hardcoded.
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #640036 -
Flags: review?(khuey)
Attachment #640036 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 7•12 years ago
|
||
Target Milestone: --- → mozilla16
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•