Closed
Bug 772406
Opened 12 years ago
Closed 12 years ago
Make nsSVGGlyphFrame::UpdateBounds reuse GetBBoxContribution
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
nsSVGGlyphFrame::UpdateBounds should reuse GetBBoxContribution instead of duplicating code.
|
Assignee | |
Comment 1•12 years ago
|
||
I'm doing this separately from bug 772017, and passing flags to GetBBoxContribution that are consistent with what the code does now, even though I'm going to change them in bug 772017. This is because - although I think the patch is okay - there are so many layers of indirection in the nsSVGGlyphFrame code that it's hard to be totally sure. I want this separate patch that's as consistent with what we do now as possible so any regressions that might be caused by using GetBBoxContribution can be squarely blamed on this bug, and not flag changes.
Attachment #640577 -
Flags: review?(roc)
Attachment #640577 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•