Closed Bug 77808 Opened 24 years ago Closed 24 years ago

Search UI: Error handling or disable for offline.

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: laurel, Assigned: Bienvenu)

Details

(Whiteboard: [nsbeta1+])

Attachments

(1 file)

Using apr26 commercial trunk build. Since Offline should land fairly soon (I hope) I'm logging this bug to track the need for handling search when offline. David Bienvenu emailed me earlier in the year and stated: "I don't think we've scheduled time to implement offline search so I think we'll just fail (or disable searching of news or imap servers while offline in the search UI) . In the future, we'll definitely support offline search the way we did in 4.x " Although I know Offline is not yet fully implemented, I see in the current commercial trunk build we don't do any offline search handling at all: 1. we don't error when initiating news/IMAP searches 2. the search doesn't fail or time out 3. Stop doesn't work, user must close dialog to stop.
Keywords: nsbeta1
QA Contact: esther → laurel
Summary: Search UI: Error handling for offline. → Search UI: Error handling or disable for offline.
well, actually, I did do most of the backend work to do offline search - it's just a matter of checking the offline state and using tbe offline search (I think). So I'll look at handling this.
Assignee: gayatrib → bienvenu
marking nsbeta1+
Priority: -- → P2
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
I have this partly working - searching imap folders by header while offline works, but news fails. I don't think body search of imap folders while offline works.
Status: NEW → ASSIGNED
patch coming up for review from Navin and Seth.
Attached patch proposed fix (deleted) — Splinter Review
looks good to me. sr=sspitzer
So, to clarify: we're going with it partly working as you described or did you get it working more completely? Search will be enabled, then, in all instances but may fail it some situations without and error to user?
r=naving
the one caveat still stands - not sure what body search for imap messages will do. Since there's no guarantee that you've downloaded message bodies for a particular imap folder, I'm not sure how meaningful it would be to search the bodies. What did 4.x do?
4.x on offline IMAP body search: If it had the bodies for a folder, all went smoothly. If not, it just reported no matches.
fix checked in - I'll open a new bug for offline imap body search.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Looks OK using: 2001-05-21-04 win98 commercial trunk build 2001-05-21-08 linux rh6.2 commercial trunk build 2001-05-17-08 mac OS 9.0 Any specific issues noticed will be logged separately. Generally checked for News, IMAP. Search works on subject/sender headers. Results, if msg downloaded for offline is opened and displayed. Results which haven't been downloaded display the appropriate "not downloaded for offline" text.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: