Closed
Bug 782344
Opened 12 years ago
Closed 12 years ago
Remove unreadable elements from parsed articles
Categories
(Firefox for Android Graveyard :: Reader View, defect, P2)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
STR:
Go to http://www.amazon.com/gp/aw/s/ref=is_box_?k=50+shades+of+grey
Expected result:
The page isn't detected as readable and no icon appears
Actual result:
The reader mode icon does appear, and clicking it simply shows a single <select> element.
|
Assignee | |
Comment 1•12 years ago
|
||
<select> elements will never have readable content, so we should remove them. In this case, the change makes http://www.amazon.com/gp/aw/s/ref=is_box_?k=50+shades+of+grey no longer readable (as desired).
Attachment #651471 -
Flags: review?(lucasr.at.mozilla)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 651471 [details] [diff] [review]
remove <select> elements from reader pages
Review of attachment 651471 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #651471 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
We may also want to remove other elements while we're here...I've seen <hr>s, <button>s, and other things that shouldn't be considered readable.
|
|
||
Comment 4•12 years ago
|
||
(In reply to Brian Nicholson (:bnicholson) from comment #3)
> We may also want to remove other elements while we're here...I've seen
> <hr>s, <button>s, and other things that shouldn't be considered readable.
Good point, go for it.
|
|
Assignee | |
Updated•12 years ago
|
Summary: <select> elements appear in parsed reader mode page → Remove unreadable elements from parsed articles
|
|
||
Updated•12 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 5•12 years ago
|
||
I'm not seeing this issue any more.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•