Closed
Bug 783376
Opened 12 years ago
Closed 12 years ago
codegenerator should be able generate implementations which inherit other simple events
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(2 files)
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/plain
|
Details |
Patch coming
Assignee | ||
Comment 1•12 years ago
|
||
this simplifies CC handling so that all the generated classes have the
CC related macros and forward calls to parent, eventually nsDOMEvent which is
anyway cycle collectable.
Attachment #652566 -
Flags: review?(khuey)
Assignee | ||
Comment 2•12 years ago
|
||
This is an example .cpp when I added nsIDOMClose2Event which inherited
nsIDOMCloseEvent, and nsIDOMClose3Event which inherited nsIDOMClose2Event.
(2 and 3 added foobar2 and foobar3 properties, and to test CC stuff, I added
also target2 and target3)
Assignee | ||
Comment 3•12 years ago
|
||
Assignee | ||
Comment 4•12 years ago
|
||
Ted, with this patch the patch you wrote earlier today isn't needed to fix CCable member variable issue you got.
Comment 5•12 years ago
|
||
If you just want to dupe bug 783234 to this, that's fine. I haven't landed it yet.
Assignee | ||
Comment 6•12 years ago
|
||
Depends on when khuey might have time to review this. Or you can review this too ;)
Attachment #652566 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•