Closed Bug 785942 Opened 12 years ago Closed 12 years ago

Make sure WebMobileConnection is only defined in B2G build

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

Attachments

(3 files, 3 obsolete files)

Part 3: Update test cases to remove mozMobileConnection from global interface.
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
Part 1: Update IDL v2
(deleted), patch
sicking
: superreview+
Details | Diff | Splinter Review
Part 2: Update Impl v2
(deleted), patch
Details | Diff | Splinter Review
From Bug 784709, mozMobileConnection should be only enabled in B2G. Desktop firefox should NOT see this property under navigator.
Assignee: nobody → allstars.chh
Assignee: allstars.chh → nobody
Component: General → DOM: Device Interfaces
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Assignee: nobody → allstars.chh
Attached patch Part 1: Update IDL (obsolete) (deleted) — — Splinter Review
Hi, sicking and smaug, In order to make mozMobileConnection only exist in b2g build, I need to separate mozMobileConnection from nsIDOMNavigatorNetwork.idl first, so this is the patch for IDL modification. Can you help to review this for me ? Thanks
Attachment #655861 - Flags: superreview?(jonas)
Attachment #655861 - Flags: review?(bugs)
Attached patch Part 2: Update Impl (obsolete) (deleted) — — Splinter Review
Hi, smaug This patch updates the implementation. Thanks
Attachment #655862 - Flags: review?(bugs)
Hi, smaug This patch updates the test. Thanks
Attachment #655864 - Flags: review?(bugs)
Comment on attachment 655861 [details] [diff] [review] Part 1: Update IDL >+[scriptable, uuid(d8672694-3334-4d0d-a4c3-38fa70c265d0)] >+interface nsIDOMMozNavigatorMobileConnection : nsISupports This interface should not have nsIDOM prefix but nsI prefix.
Attachment #655861 - Flags: review?(bugs) → review+
Attachment #655862 - Flags: review?(bugs) → review+
Attachment #655864 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] (slower than usual reviews for few days) from comment #4) > Comment on attachment 655861 [details] [diff] [review] > Part 1: Update IDL > > > >+[scriptable, uuid(d8672694-3334-4d0d-a4c3-38fa70c265d0)] > >+interface nsIDOMMozNavigatorMobileConnection : nsISupports > > This interface should not have nsIDOM prefix but nsI prefix. Hi, smaug Should I need to rename the filename nsIDOMNavigatorMobileConnection.idl to nsINavigatorMobileConnection.idl as well ?
Attached patch Part 1: Update IDL v2 (deleted) — — Splinter Review
Address to smaug's comments, also rename the filename as well.
Attachment #655861 - Attachment is obsolete: true
Attachment #655861 - Flags: superreview?(jonas)
Attachment #656126 - Flags: superreview?(jonas)
Attached patch Part 1: Update IDL v2 (obsolete) (deleted) — — Splinter Review
Address to smaug's comments, also rename the filename as well.
Attachment #655862 - Attachment is obsolete: true
Attachment #656128 - Flags: superreview?(jonas)
Comment on attachment 656128 [details] [diff] [review] Part 1: Update IDL v2 network problem, update the same problem twice.
Attachment #656128 - Attachment is obsolete: true
Attachment #656128 - Flags: superreview?(jonas)
Attachment #656126 - Flags: superreview?(jonas) → superreview+
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: