Closed Bug 78655 Opened 24 years ago Closed 23 years ago

[console] os/2 port should not print to console in opt builds

Categories

(Core :: XUL, defect, P2)

x86
OS/2
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: cls, Assigned: mkaply)

References

Details

Attachments

(1 file)

<formletter>It has been decreed (or requested at any rate) that our release (read non-debug) builds must not print anything to the console when the app is running. See bug 76720 for details. I have done a preliminary tree scouring and created mini-patches for each module that has bare printfs. These patches are not all inclusive as I didn't even think about xul/js output until post scour so module owners & peers will still need to scour their modules themselves as well as make sure the preliminary patches do not break anything.</formletter>
Blocks: 76720
Keywords: mozilla0.9.1
Priority: -- → P2
Attached patch prelim patch (deleted) — Splinter Review
Chris, we already do this on OS/2. Our release builds are marked as a windowing app in the exe header and therefore OS/2 will automatically not associate a console with it. Even if there are printf() calls, they will go to /dev/null. Might be unpretty to the printf()s but they should go away soon....
Sorry about the additional spammage but I should clear up a couple of things before everyone starts replying. 1) I'm just the messenger. Discussions outside of the specific module/patches should be discussed in the parent bug ( bug 76720). 2) I have no intention of checking in the patches as is; that's why the bugs are assigned to someone else ;). 3) The patches are the result of a far & wide-reaching grep across the entire tree. They may affect some cases that are not even used and they are far from optimal. 4) Some platforms/ports will not need the printfs shutoff as they use other mechanisms to stop the printfs. That's fine. Note it in the bug and close it as invalid(?). Depending upon the platform/port some people may still be interested in removing the overhead from the printfs.
Target Milestone: --- → mozilla1.0
lets keep dribbling these [console] bugs into the tree as quick as we can, but they shouldn't hold up or block 0.9.1 so moving the target milestone to 0.9.2.
Target Milestone: mozilla1.0 → mozilla0.9.2
Checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
marking verified per cvs.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: