Closed Bug 786613 Opened 12 years ago Closed 12 years ago

Port |Bug 782453 - Add site-specific User Agent infrastructure| to SeaMonkey

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(seamonkey2.14 fixed)

RESOLVED FIXED
seamonkey2.15
Tracking Status
seamonkey2.14 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(2 files)

Bug 387416 was WONTFIXed but now we have the requisite infrastructure courtesy of Firefox. All we need is to port the front end and Bob's your uncle. CC the usual suspects.
I find it so incredibly funny that Mozilla people were such a lot against having a mechanism like that when we needed it, but now have just gone and done it when Firefox for Android and even B2G wanted it.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
To test. 1. Create a string preference: general.useragent.override.browserspy.dk 2. With a value of: Gecko/[^ ]*#Gecko/20120831 3. Visit: http://browserspy.dk/useragent.php
Attachment #657142 - Flags: review?(neil)
Comment on attachment 657142 [details] [diff] [review] Patch v1.0 front end changes for SeaMonkey I'll take your word for it that it works, but do we need any packaging changes?
Attachment #657142 - Flags: review?(neil) → review+
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/9e6f4b466746 > I'll take your word for it that it works, but do we need any packaging changes? We might need an entry in removed-files.in . CC serge for a definitive answer. Leaving open for the time being.
Target Milestone: --- → seamonkey2.15
Attached patch Patch Pv1.0 removed-files.in (deleted) — Splinter Review
Installer/Packaging changes.
Attachment #657574 - Flags: review?(sgautherie.bz)
Comment on attachment 657574 [details] [diff] [review] Patch Pv1.0 removed-files.in Ftr, I feel like (adding) this part is often missed, probably because we don't notice (anymore) that a jsm was added (in mozilla-central).
Attachment #657574 - Flags: review?(sgautherie.bz) → review+
Depends on: 782453
Summary: Port |Bug 782453 - Add site-specific User Agent infrastructure| → Port |Bug 782453 - Add site-specific User Agent infrastructure| to SeaMonkey
Pushed packaging changes to comm-central http://hg.mozilla.org/comm-central/rev/31e75338b940
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 657142 [details] [diff] [review] Patch v1.0 front end changes for SeaMonkey See Bug 782453 Comment 41: [Approval Request Comment] Regression caused by (bug #): Bug 782453 / bug 588909 User impact if declined: bug 778408 Testing completed (on m-c, etc.): manual on comm-central. Firefox patch baked on FX17 and FX18. Risk to taking this patch (and alternatives if risky): low, no fallout expected String changes made by this patch: none Also I need to land Bug 801318 on branches but that applies on top of this patch.
Attachment #657142 - Flags: approval-comm-beta?
Attachment #657142 - Flags: approval-comm-aurora?
Comment on attachment 657142 [details] [diff] [review] Patch v1.0 front end changes for SeaMonkey Hmm, wasn't the new pref introduced here just removed from trunk and all branches (bug 797363)? [You can of course remove the pref with another patch, just wanted to note it.]
Attachment #657142 - Flags: approval-comm-beta?
Attachment #657142 - Flags: approval-comm-beta+
Attachment #657142 - Flags: approval-comm-aurora?
Attachment #657142 - Flags: approval-comm-aurora+
Comment on attachment 657142 [details] [diff] [review] Patch v1.0 front end changes for SeaMonkey Cancelling a-aurora because it made the merge. Pushed: http://hg.mozilla.org/releases/comm-beta/rev/e86a3f550aee http://hg.mozilla.org/releases/comm-beta/rev/a06ccb779651
Attachment #657142 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: